From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/ricci/include counting_auto_ptr.cpp coun ...
Date: 4 Sep 2007 18:30:47 -0000 [thread overview]
Message-ID: <20070904183047.20978.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: conga
Changes by: rmccabe at sourceware.org 2007-09-04 18:30:46
Modified files:
ricci/include : counting_auto_ptr.cpp counting_auto_ptr.h
Log message:
don't dynamically allocate the reference counter int on the heap
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/include/counting_auto_ptr.cpp.diff?cvsroot=cluster&r1=1.2&r2=1.3
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/include/counting_auto_ptr.h.diff?cvsroot=cluster&r1=1.2&r2=1.3
--- conga/ricci/include/counting_auto_ptr.cpp 2007/08/31 13:32:36 1.2
+++ conga/ricci/include/counting_auto_ptr.cpp 2007/09/04 18:30:46 1.3
@@ -29,7 +29,7 @@
_ptr(ptr)
{
try {
- _counter = new int(1);
+ _counter = 1;
} catch ( ... ) {
delete _ptr;
throw;
@@ -39,7 +39,6 @@
_mutex = new Mutex();
} catch ( ... ) {
delete _ptr;
- delete _counter;
throw;
}
};
@@ -51,7 +50,7 @@
_ptr = o._ptr;
_mutex = o._mutex;
_counter = o._counter;
- (*_counter)++;
+ _counter++;
};
template<class X>
@@ -64,7 +63,7 @@
_ptr = o._ptr;
_mutex = o._mutex;
_counter = o._counter;
- (*_counter)++;
+ _counter++;
}
return *this;
};
@@ -82,11 +81,10 @@
bool last = false;
{
MutexLocker l(*_mutex);
- last = (--(*_counter) == 0);
+ last = (--_counter == 0);
}
if (last) {
- delete _counter;
delete _ptr;
delete _mutex;
}
--- conga/ricci/include/counting_auto_ptr.h 2007/08/31 13:32:36 1.2
+++ conga/ricci/include/counting_auto_ptr.h 2007/09/04 18:30:46 1.3
@@ -47,7 +47,7 @@
private:
X* _ptr;
Mutex* _mutex;
- int* _counter;
+ int _counter;
void decrease_counter();
};
next reply other threads:[~2007-09-04 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 18:30 rmccabe [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-04 21:28 [Cluster-devel] conga/ricci/include counting_auto_ptr.cpp coun rmccabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070904183047.20978.qmail@sourceware.org \
--to=rmccabe@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).