From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/ricci/include counting_auto_ptr.cpp coun ...
Date: 4 Sep 2007 21:28:06 -0000 [thread overview]
Message-ID: <20070904212806.20823.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: conga
Changes by: rmccabe at sourceware.org 2007-09-04 21:28:05
Modified files:
ricci/include : counting_auto_ptr.cpp counting_auto_ptr.h
Log message:
More debugging, make the refcounter an int * again
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/include/counting_auto_ptr.cpp.diff?cvsroot=cluster&r1=1.4&r2=1.5
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/include/counting_auto_ptr.h.diff?cvsroot=cluster&r1=1.3&r2=1.4
--- conga/ricci/include/counting_auto_ptr.cpp 2007/09/04 18:43:26 1.4
+++ conga/ricci/include/counting_auto_ptr.cpp 2007/09/04 21:28:05 1.5
@@ -28,12 +28,18 @@
counting_auto_ptr<X>::counting_auto_ptr(X* ptr) :
_ptr(ptr)
{
- _counter = 1;
+ try {
+ _counter = new int(1);
+ } catch ( ... ) {
+ delete _ptr;
+ throw;
+ }
try {
_mutex = new Mutex();
} catch ( ... ) {
delete _ptr;
+ delete _counter;
throw;
}
};
@@ -45,7 +51,7 @@
_ptr = o._ptr;
_mutex = o._mutex;
_counter = o._counter;
- _counter++;
+ (*_counter)++;
};
template<class X>
@@ -58,7 +64,7 @@
_ptr = o._ptr;
_mutex = o._mutex;
_counter = o._counter;
- _counter++;
+ (*_counter)++;
}
return *this;
};
@@ -76,10 +82,14 @@
bool last = false;
{
MutexLocker l(*_mutex);
- last = (--_counter == 0);
+ last = (--(*_counter) == 0);
+ if (*_counter < 0)
+ throw int();
}
if (last) {
+ delete _counter;
+ _counter = NULL;
delete _ptr;
_ptr = NULL;
delete _mutex;
@@ -102,6 +112,9 @@
X*
counting_auto_ptr<X>::operator->() const
{
+#ifdef DEBUG
+ assert(_ptr != NULL);
+#endif
return _ptr;
};
--- conga/ricci/include/counting_auto_ptr.h 2007/09/04 18:30:46 1.3
+++ conga/ricci/include/counting_auto_ptr.h 2007/09/04 21:28:05 1.4
@@ -47,7 +47,7 @@
private:
X* _ptr;
Mutex* _mutex;
- int _counter;
+ int *_counter;
void decrease_counter();
};
next reply other threads:[~2007-09-04 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 21:28 rmccabe [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-04 18:30 [Cluster-devel] conga/ricci/include counting_auto_ptr.cpp coun rmccabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070904212806.20823.qmail@sourceware.org \
--to=rmccabe@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).