From: Benjamin Marzinski <bmarzins@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] [GFS2] bz253089 Make gfs2_writepage use trylock on the log_flush lock
Date: Thu, 13 Sep 2007 11:30:37 -0500 [thread overview]
Message-ID: <20070913163037.GB5841@ether.msp.redhat.com> (raw)
gfs2 was deadlocking because most code paths acquire the sd_log_flush_lock and
then the page locks, while code paths going through gfs2_writepage acquire the
page locks and then the log flush lock.
This patch makes gfs2_writepage do a trylock on the sd_log_flush_lock. If it
fails, writepage simply redirtys the page and gives up. This should keep the
deadlock from happening, however it might cause a performance hit.
Signed-off-by: Benjamin E. Marzinski <bmarzins@redhat.com>
next reply other threads:[~2007-09-13 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 16:30 Benjamin Marzinski [this message]
2007-09-13 16:36 ` [Cluster-devel] [PATCH] [GFS2] bz253089 Make gfs2_writepage use trylock on the log_flush lock Benjamin Marzinski
2007-09-14 16:50 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913163037.GB5841@ether.msp.redhat.com \
--to=bmarzins@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).