From: fabbione@sourceware.org <fabbione@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster configure
Date: 28 Sep 2007 06:19:08 -0000 [thread overview]
Message-ID: <20070928061908.24815.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: fabbione at sourceware.org 2007-09-28 06:19:08
Modified files:
. : configure
Log message:
configure: Backticks don't work in strings. Use POSIX::uname().
The strings that use backticks to get `uname -r` don't work as expected.
Let's use POSIX::uname() directly and let perl do the work.
Patch by Joel Becker <joel.becker@oracle.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/configure.diff?cvsroot=cluster&r1=1.34&r2=1.35
--- cluster/configure 2007/09/24 14:43:13 1.34
+++ cluster/configure 2007/09/28 06:19:08 1.35
@@ -14,6 +14,7 @@
###############################################################################
use Getopt::Long;
+use POSIX qw(uname);
print "\nConfiguring Makefiles for your system...\n";
@@ -228,22 +229,24 @@
if (!$prefix) {
$prefix="/usr";
}
+
+my @un = POSIX::uname();
if (!$kernel_build) {
- if (-d "/lib/modules/`uname -r`/build") {
- $kernel_build="/lib/modules/`uname -r`/build";
+ if (-d "/lib/modules/$un[2]/build") {
+ $kernel_build="/lib/modules/$un[2]/build";
} else {
$kernel_build="/usr/src/linux";
}
}
if (!$kernel_src) {
- if (-d "/lib/modules/`uname -r`/source") {
- $kernel_src="/lib/modules/`uname -r`/source";
+ if (-d "/lib/modules/$un[2]/source") {
+ $kernel_src="/lib/modules/$un[2]/source";
} else {
$kernel_src=$kernel_build;
}
}
if (!$module_dir) {
- $module_dir="/lib/modules/`uname -r`/kernel";
+ $module_dir="/lib/modules/$un[2]/kernel";
}
if (!$gfskincdir) {
$gfskincdir="${pwd}/gfs-kernel/src/gfs";
next reply other threads:[~2007-09-28 6:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 6:19 fabbione [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-28 6:43 [Cluster-devel] cluster configure fabbione
2008-01-07 18:58 lhh
2007-12-21 7:28 fabbione
2007-12-21 5:58 fabbione
2007-12-19 5:48 fabbione
2007-12-06 10:38 pcaulfield
2007-11-24 4:57 fabbione
2007-10-26 19:18 rmccabe
2007-10-01 3:28 fabbione
2007-09-24 14:43 fabbione
2007-09-14 14:32 teigland
2007-09-06 16:26 teigland
2007-09-06 16:24 teigland
2007-06-06 8:42 fabbione
2007-05-21 10:16 pcaulfield
2006-10-05 16:50 teigland
2006-08-02 22:47 rpeterso
2006-07-19 17:13 teigland
2006-07-19 14:51 teigland
2006-07-19 14:04 rpeterso
2006-06-28 19:54 jbrassow
2006-06-14 20:44 cfeist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928061908.24815.qmail@sourceware.org \
--to=fabbione@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).