From: rpeterso@sourceware.org <rpeterso@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs2/edit savemeta.c
Date: 19 Oct 2007 03:22:06 -0000 [thread overview]
Message-ID: <20071019032206.9484.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: rpeterso at sourceware.org 2007-10-19 03:22:06
Modified files:
gfs2/edit : savemeta.c
Log message:
Minor correction to the previous commit. Bopping through indirect
pointers was inadvertently changing variable "block" during savemeta.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs2/edit/savemeta.c.diff?cvsroot=cluster&r1=1.4&r2=1.5
--- cluster/gfs2/edit/savemeta.c 2007/10/18 19:56:41 1.4
+++ cluster/gfs2/edit/savemeta.c 2007/10/19 03:22:05 1.5
@@ -536,11 +536,12 @@
void save_indirect_blocks(int out_fd, osi_list_t *cur_list,
struct gfs2_buffer_head *mybh, int height, int hgt)
{
- uint64_t old_block = 0;
+ uint64_t old_block = 0, starting_block;
uint64_t *ptr;
int head_size;
struct gfs2_buffer_head *nbh;
+ starting_block = block; /* remember where we started */
head_size = (hgt > 1 ?
sizeof(struct gfs2_meta_header) :
sizeof(struct gfs2_dinode));
@@ -561,6 +562,7 @@
brelse(nbh, not_updated);
}
} /* for all data on the indirect block */
+ block = starting_block; /* go back to where we started */
}
/*
next reply other threads:[~2007-10-19 3:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 3:22 rpeterso [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-06-26 1:53 [Cluster-devel] cluster/gfs2/edit savemeta.c rpeterso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071019032206.9484.qmail@sourceware.org \
--to=rpeterso@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).