From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Tue, 23 Oct 2007 13:15:39 -0500 Subject: [Cluster-devel] spectator setting in cluster.conf In-Reply-To: <471E2838.9060703@ubuntu.com> References: <20071022151200.GA26370@redhat.com> <471D85B3.5020405@ubuntu.com> <20071023134507.GA23832@redhat.com> <471E2838.9060703@ubuntu.com> Message-ID: <20071023181539.GC23832@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Oct 23, 2007 at 06:58:32PM +0200, Fabio Massimo Di Nitto wrote: > > An explicit votes= setting for a node would override the 0 votes implied > > by . > > So ok. I need to understand you better because I think what I wrote > before is in contradiction with this override. > > In my patch spectator overrides votes="" no matter if they are specified > or not. > > Here you say that spectator overrides automatic setting of votes="" when > votes="" is not specified in the config. So in my head this implies two > config changes to set a node to spectator. Remove the votes="" entry (if > any and IME is quite common in the configs) and add spectator. > > I think it makes more sense (to me) to override votes="" in full when > spectator is set. If no votes are specified, the default is 1. If no votes are specified and exists, then the default is 0. If you want to override either of these defaults, then you include votes="N". A specified value must always override a default value. If an existing cluster.conf has , the votes setting is obviously extraneous. And making this node a full spectator would require either: - changing to an explicit votes="0" and adding , or - removing the explicit votes setting altogether and adding It needs to be possible to have a spectator node with 1 vote (or more), and if you're saying that this config: should *not* work to do that, then it's madness :-) Dave