cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/rgmanager/src/clulib clulog.c msg_socket.c
Date: 29 Oct 2007 17:52:53 -0000	[thread overview]
Message-ID: <20071029175253.22708.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL5
Changes by:	rmccabe at sourceware.org	2007-10-29 17:52:53

Modified files:
	rgmanager/src/clulib: clulog.c msg_socket.c 

Log message:
	Fix format string bugs

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/clulog.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.5.2.1&r2=1.5.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/msg_socket.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.1&r2=1.1.2.1

--- cluster/rgmanager/src/clulib/clulog.c	2007/05/10 16:23:43	1.5.2.1
+++ cluster/rgmanager/src/clulib/clulog.c	2007/10/29 17:52:52	1.5.2.2
@@ -20,7 +20,7 @@
 /** @file
  * Library routines for communicating with the logging daemon.
  *
- *  $Id: clulog.c,v 1.5.2.1 2007/05/10 16:23:43 lhh Exp $
+ *  $Id: clulog.c,v 1.5.2.2 2007/10/29 17:52:52 rmccabe Exp $
  *
  *  Author: Jeff Moyer <moyer@missioncriticallinux.com>
  */
@@ -50,7 +50,7 @@
 #include <string.h>
 
 
-static const char *version __attribute__ ((unused)) = "$Revision: 1.5.2.1 $";
+static const char *version __attribute__ ((unused)) = "$Revision: 1.5.2.2 $";
 
 #ifdef DEBUG
 #include <assert.h>
@@ -283,7 +283,7 @@
 		fprintf(stdout, "%s", printmsg);
 	}
 
-	syslog(severity, logmsg);
+	syslog(severity, "%s", logmsg);
 
 	pthread_mutex_unlock(&log_mutex);
 
--- cluster/rgmanager/src/clulib/msg_socket.c	2006/07/11 23:52:41	1.1
+++ cluster/rgmanager/src/clulib/msg_socket.c	2007/10/29 17:52:52	1.1.2.1
@@ -44,7 +44,7 @@
 
 	memset(&sun, 0, sizeof(sun));
 	sun.sun_family = PF_LOCAL;
-	snprintf(sun.sun_path, sizeof(sun.sun_path), RGMGR_SOCK);
+	snprintf(sun.sun_path, sizeof(sun.sun_path), "%s", RGMGR_SOCK);
 
 	sock = socket(PF_LOCAL, SOCK_STREAM, 0);
 	if (sock < 0) {
@@ -362,7 +362,7 @@
 	unlink(RGMGR_SOCK);
 	om = umask(077);
 	su.sun_family = PF_LOCAL;
-	snprintf(su.sun_path, sizeof(su.sun_path), path);
+	snprintf(su.sun_path, sizeof(su.sun_path), "%s", path);
 
 	if (bind(sock, &su, sizeof(su)) < 0) {
 		umask(om);



             reply	other threads:[~2007-10-29 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29 17:52 rmccabe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-10-29 17:51 [Cluster-devel] cluster/rgmanager/src/clulib clulog.c msg_socket.c rmccabe
2007-10-29 17:48 rmccabe
2007-10-26 19:02 rmccabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071029175253.22708.qmail@sourceware.org \
    --to=rmccabe@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).