* [Cluster-devel] cluster/rgmanager/src/clulib clulog.c msg_socket.c
@ 2007-10-29 17:52 rmccabe
0 siblings, 0 replies; 4+ messages in thread
From: rmccabe @ 2007-10-29 17:52 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: rmccabe at sourceware.org 2007-10-29 17:52:53
Modified files:
rgmanager/src/clulib: clulog.c msg_socket.c
Log message:
Fix format string bugs
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/clulog.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.5.2.1&r2=1.5.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/msg_socket.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.1&r2=1.1.2.1
--- cluster/rgmanager/src/clulib/clulog.c 2007/05/10 16:23:43 1.5.2.1
+++ cluster/rgmanager/src/clulib/clulog.c 2007/10/29 17:52:52 1.5.2.2
@@ -20,7 +20,7 @@
/** @file
* Library routines for communicating with the logging daemon.
*
- * $Id: clulog.c,v 1.5.2.1 2007/05/10 16:23:43 lhh Exp $
+ * $Id: clulog.c,v 1.5.2.2 2007/10/29 17:52:52 rmccabe Exp $
*
* Author: Jeff Moyer <moyer@missioncriticallinux.com>
*/
@@ -50,7 +50,7 @@
#include <string.h>
-static const char *version __attribute__ ((unused)) = "$Revision: 1.5.2.1 $";
+static const char *version __attribute__ ((unused)) = "$Revision: 1.5.2.2 $";
#ifdef DEBUG
#include <assert.h>
@@ -283,7 +283,7 @@
fprintf(stdout, "%s", printmsg);
}
- syslog(severity, logmsg);
+ syslog(severity, "%s", logmsg);
pthread_mutex_unlock(&log_mutex);
--- cluster/rgmanager/src/clulib/msg_socket.c 2006/07/11 23:52:41 1.1
+++ cluster/rgmanager/src/clulib/msg_socket.c 2007/10/29 17:52:52 1.1.2.1
@@ -44,7 +44,7 @@
memset(&sun, 0, sizeof(sun));
sun.sun_family = PF_LOCAL;
- snprintf(sun.sun_path, sizeof(sun.sun_path), RGMGR_SOCK);
+ snprintf(sun.sun_path, sizeof(sun.sun_path), "%s", RGMGR_SOCK);
sock = socket(PF_LOCAL, SOCK_STREAM, 0);
if (sock < 0) {
@@ -362,7 +362,7 @@
unlink(RGMGR_SOCK);
om = umask(077);
su.sun_family = PF_LOCAL;
- snprintf(su.sun_path, sizeof(su.sun_path), path);
+ snprintf(su.sun_path, sizeof(su.sun_path), "%s", path);
if (bind(sock, &su, sizeof(su)) < 0) {
umask(om);
^ permalink raw reply [flat|nested] 4+ messages in thread* [Cluster-devel] cluster/rgmanager/src/clulib clulog.c msg_socket.c
@ 2007-10-29 17:51 rmccabe
0 siblings, 0 replies; 4+ messages in thread
From: rmccabe @ 2007-10-29 17:51 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL51
Changes by: rmccabe at sourceware.org 2007-10-29 17:51:09
Modified files:
rgmanager/src/clulib: clulog.c msg_socket.c
Log message:
Whoops. Reverting last commit. Meant to commit to -RHEL5, not RHEL51
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/clulog.c.diff?cvsroot=cluster&only_with_tag=RHEL51&r1=1.5.2.1.2.1&r2=1.5.2.1.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/msg_socket.c.diff?cvsroot=cluster&only_with_tag=RHEL51&r1=1.1.6.1&r2=1.1.6.2
--- cluster/rgmanager/src/clulib/clulog.c 2007/10/29 17:48:54 1.5.2.1.2.1
+++ cluster/rgmanager/src/clulib/clulog.c 2007/10/29 17:51:08 1.5.2.1.2.2
@@ -20,7 +20,7 @@
/** @file
* Library routines for communicating with the logging daemon.
*
- * $Id: clulog.c,v 1.5.2.1.2.1 2007/10/29 17:48:54 rmccabe Exp $
+ * $Id: clulog.c,v 1.5.2.1.2.2 2007/10/29 17:51:08 rmccabe Exp $
*
* Author: Jeff Moyer <moyer@missioncriticallinux.com>
*/
@@ -50,7 +50,7 @@
#include <string.h>
-static const char *version __attribute__ ((unused)) = "$Revision: 1.5.2.1.2.1 $";
+static const char *version __attribute__ ((unused)) = "$Revision: 1.5.2.1.2.2 $";
#ifdef DEBUG
#include <assert.h>
@@ -283,7 +283,7 @@
fprintf(stdout, "%s", printmsg);
}
- syslog(severity, "%s", logmsg);
+ syslog(severity, logmsg);
pthread_mutex_unlock(&log_mutex);
--- cluster/rgmanager/src/clulib/msg_socket.c 2007/10/29 17:48:54 1.1.6.1
+++ cluster/rgmanager/src/clulib/msg_socket.c 2007/10/29 17:51:08 1.1.6.2
@@ -362,7 +362,7 @@
unlink(RGMGR_SOCK);
om = umask(077);
su.sun_family = PF_LOCAL;
- snprintf(su.sun_path, sizeof(su.sun_path), "%s", path);
+ snprintf(su.sun_path, sizeof(su.sun_path), path);
if (bind(sock, &su, sizeof(su)) < 0) {
umask(om);
^ permalink raw reply [flat|nested] 4+ messages in thread* [Cluster-devel] cluster/rgmanager/src/clulib clulog.c msg_socket.c
@ 2007-10-29 17:48 rmccabe
0 siblings, 0 replies; 4+ messages in thread
From: rmccabe @ 2007-10-29 17:48 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL51
Changes by: rmccabe at sourceware.org 2007-10-29 17:48:55
Modified files:
rgmanager/src/clulib: clulog.c msg_socket.c
Log message:
fix two format string bugs
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/clulog.c.diff?cvsroot=cluster&only_with_tag=RHEL51&r1=1.5.2.1&r2=1.5.2.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/msg_socket.c.diff?cvsroot=cluster&only_with_tag=RHEL51&r1=1.1&r2=1.1.6.1
--- cluster/rgmanager/src/clulib/clulog.c 2007/05/10 16:23:43 1.5.2.1
+++ cluster/rgmanager/src/clulib/clulog.c 2007/10/29 17:48:54 1.5.2.1.2.1
@@ -20,7 +20,7 @@
/** @file
* Library routines for communicating with the logging daemon.
*
- * $Id: clulog.c,v 1.5.2.1 2007/05/10 16:23:43 lhh Exp $
+ * $Id: clulog.c,v 1.5.2.1.2.1 2007/10/29 17:48:54 rmccabe Exp $
*
* Author: Jeff Moyer <moyer@missioncriticallinux.com>
*/
@@ -50,7 +50,7 @@
#include <string.h>
-static const char *version __attribute__ ((unused)) = "$Revision: 1.5.2.1 $";
+static const char *version __attribute__ ((unused)) = "$Revision: 1.5.2.1.2.1 $";
#ifdef DEBUG
#include <assert.h>
@@ -283,7 +283,7 @@
fprintf(stdout, "%s", printmsg);
}
- syslog(severity, logmsg);
+ syslog(severity, "%s", logmsg);
pthread_mutex_unlock(&log_mutex);
--- cluster/rgmanager/src/clulib/msg_socket.c 2006/07/11 23:52:41 1.1
+++ cluster/rgmanager/src/clulib/msg_socket.c 2007/10/29 17:48:54 1.1.6.1
@@ -362,7 +362,7 @@
unlink(RGMGR_SOCK);
om = umask(077);
su.sun_family = PF_LOCAL;
- snprintf(su.sun_path, sizeof(su.sun_path), path);
+ snprintf(su.sun_path, sizeof(su.sun_path), "%s", path);
if (bind(sock, &su, sizeof(su)) < 0) {
umask(om);
^ permalink raw reply [flat|nested] 4+ messages in thread* [Cluster-devel] cluster/rgmanager/src/clulib clulog.c msg_socket.c
@ 2007-10-26 19:02 rmccabe
0 siblings, 0 replies; 4+ messages in thread
From: rmccabe @ 2007-10-26 19:02 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: rmccabe at sourceware.org 2007-10-26 19:02:43
Modified files:
rgmanager/src/clulib: clulog.c msg_socket.c
Log message:
rgmanager format string fixes
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/clulog.c.diff?cvsroot=cluster&r1=1.7&r2=1.8
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/clulib/msg_socket.c.diff?cvsroot=cluster&r1=1.1&r2=1.2
--- cluster/rgmanager/src/clulib/clulog.c 2007/04/30 11:22:23 1.7
+++ cluster/rgmanager/src/clulib/clulog.c 2007/10/26 19:02:43 1.8
@@ -20,7 +20,7 @@
/** @file
* Library routines for communicating with the logging daemon.
*
- * $Id: clulog.c,v 1.7 2007/04/30 11:22:23 fabbione Exp $
+ * $Id: clulog.c,v 1.8 2007/10/26 19:02:43 rmccabe Exp $
*
* Author: Jeff Moyer <moyer@missioncriticallinux.com>
*/
@@ -49,7 +49,7 @@
#include <string.h>
-static const char *version __attribute__ ((unused)) = "$Revision: 1.7 $";
+static const char *version __attribute__ ((unused)) = "$Revision: 1.8 $";
#ifdef DEBUG
#include <assert.h>
@@ -282,7 +282,7 @@
fprintf(stdout, "%s", printmsg);
}
- syslog(severity, logmsg);
+ syslog(severity, "%s", logmsg);
pthread_mutex_unlock(&log_mutex);
--- cluster/rgmanager/src/clulib/msg_socket.c 2006/07/11 23:52:41 1.1
+++ cluster/rgmanager/src/clulib/msg_socket.c 2007/10/26 19:02:43 1.2
@@ -362,7 +362,7 @@
unlink(RGMGR_SOCK);
om = umask(077);
su.sun_family = PF_LOCAL;
- snprintf(su.sun_path, sizeof(su.sun_path), path);
+ snprintf(su.sun_path, sizeof(su.sun_path), "%s", path);
if (bind(sock, &su, sizeof(su)) < 0) {
umask(om);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-29 17:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-29 17:52 [Cluster-devel] cluster/rgmanager/src/clulib clulog.c msg_socket.c rmccabe
-- strict thread matches above, loose matches on Subject: below --
2007-10-29 17:51 rmccabe
2007-10-29 17:48 rmccabe
2007-10-26 19:02 rmccabe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).