* [Cluster-devel] cluster/group/gfs_controld lock_dlm.h
@ 2007-11-21 17:49 teigland
0 siblings, 0 replies; 3+ messages in thread
From: teigland @ 2007-11-21 17:49 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: teigland at sourceware.org 2007-11-21 17:49:16
Modified files:
group/gfs_controld: lock_dlm.h
Log message:
ASSERT was doing fprintf(stderr) which goes somewhere we don't want
when running as a daemon.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/gfs_controld/lock_dlm.h.diff?cvsroot=cluster&r1=1.29&r2=1.30
--- cluster/group/gfs_controld/lock_dlm.h 2007/09/04 19:22:52 1.29
+++ cluster/group/gfs_controld/lock_dlm.h 2007/11/21 17:49:16 1.30
@@ -105,13 +105,12 @@
} while (0)
#define ASSERT(x) \
-{ \
+do { \
if (!(x)) { \
- fprintf(stderr, "\nAssertion failed on line %d of file %s\n\n" \
- "Assertion: \"%s\"\n", \
- __LINE__, __FILE__, #x); \
- } \
-}
+ log_error("Assertion failed on line %d of file %s\n" \
+ "Assertion: \"%s\"\n", __LINE__, __FILE__, #x); \
+ } \
+} while (0)
struct mountpoint {
struct list_head list;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] cluster/group/gfs_controld lock_dlm.h
@ 2007-11-21 17:50 teigland
2007-11-21 18:19 ` David Teigland
0 siblings, 1 reply; 3+ messages in thread
From: teigland @ 2007-11-21 17:50 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: teigland at sourceware.org 2007-11-21 17:50:16
Modified files:
group/gfs_controld: lock_dlm.h
Log message:
ASSERT was doing fprintf(stderr) which goes somewhere we don't want
when running as a daemon.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/gfs_controld/lock_dlm.h.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.21.2.8&r2=1.21.2.9
--- cluster/group/gfs_controld/lock_dlm.h 2007/09/04 19:27:34 1.21.2.8
+++ cluster/group/gfs_controld/lock_dlm.h 2007/11/21 17:50:15 1.21.2.9
@@ -105,13 +105,12 @@
} while (0)
#define ASSERT(x) \
-{ \
+do { \
if (!(x)) { \
- fprintf(stderr, "\nAssertion failed on line %d of file %s\n\n" \
- "Assertion: \"%s\"\n", \
- __LINE__, __FILE__, #x); \
- } \
-}
+ log_error("Assertion failed on line %d of file %s\n" \
+ "Assertion: \"%s\"\n", __LINE__, __FILE__, #x); \
+ } \
+} while (0)
struct mountpoint {
struct list_head list;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] cluster/group/gfs_controld lock_dlm.h
2007-11-21 17:50 teigland
@ 2007-11-21 18:19 ` David Teigland
0 siblings, 0 replies; 3+ messages in thread
From: David Teigland @ 2007-11-21 18:19 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Wed, Nov 21, 2007 at 05:50:16PM -0000, teigland at sourceware.org wrote:
> CVSROOT: /cvs/cluster
> Module name: cluster
> Branch: RHEL5
> Changes by: teigland at sourceware.org 2007-11-21 17:50:16
>
> Modified files:
> group/gfs_controld: lock_dlm.h
>
> Log message:
> ASSERT was doing fprintf(stderr) which goes somewhere we don't want
> when running as a daemon.
created bz 394721 for this
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-21 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-21 17:49 [Cluster-devel] cluster/group/gfs_controld lock_dlm.h teigland
-- strict thread matches above, loose matches on Subject: below --
2007-11-21 17:50 teigland
2007-11-21 18:19 ` David Teigland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).