cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/gfs_controld plock.c
Date: 29 Nov 2007 21:27:59 -0000	[thread overview]
Message-ID: <20071129212759.22284.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	teigland at sourceware.org	2007-11-29 21:27:58

Modified files:
	group/gfs_controld: plock.c 

Log message:
	Testing revealed a couple more races I hadn't expected.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/gfs_controld/plock.c.diff?cvsroot=cluster&r1=1.34&r2=1.35

--- cluster/group/gfs_controld/plock.c	2007/11/28 20:49:08	1.34
+++ cluster/group/gfs_controld/plock.c	2007/11/29 21:27:58	1.35
@@ -1404,8 +1404,12 @@
 	}
 
 	if (r->owner != 0) {
-		/* shouldn't happen */
-		log_error("receive_drop from %d r %llx owner %d", from,
+		/* - A sent drop, B sent drop, receive drop A, C sent own,
+		     receive drop B (this warning on C, owner -1)
+	   	   - A sent drop, B sent drop, receive drop A, A sent own,
+		     receive own A, receive drop B (this warning on all,
+		     owner A) */
+		log_debug("receive_drop from %d r %llx owner %d", from,
 			  (unsigned long long)r->number, r->owner);
 		return;
 	}



             reply	other threads:[~2007-11-29 21:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 21:27 teigland [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-21 20:21 [Cluster-devel] cluster/group/gfs_controld plock.c teigland
2008-01-21 20:19 teigland
2008-01-21 20:17 teigland
2007-11-30 16:20 teigland
2007-06-08 21:31 teigland
2007-06-08 21:30 teigland
2006-11-20 21:29 teigland
2006-11-20 21:29 teigland
2006-11-20 21:28 teigland
2006-11-20 18:13 teigland
2006-11-20 18:12 teigland
2006-11-20 18:10 teigland
2006-11-03 15:33 teigland
2006-10-09 21:51 teigland
2006-08-17 19:39 teigland
2006-08-16 19:30 teigland
2006-08-16 17:05 teigland
2006-08-15 22:21 rpeterso
2006-08-14 20:15 teigland
2006-08-08 19:37 teigland
2006-08-08 18:43 teigland
2006-08-02 19:23 teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071129212759.22284.qmail@sourceware.org \
    --to=teigland@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).