From mboxrd@z Thu Jan  1 00:00:00 1970
From: teigland@sourceware.org <teigland@sourceware.org>
Date: 30 Nov 2007 16:20:56 -0000
Subject: [Cluster-devel] cluster/group/gfs_controld plock.c
Message-ID: <20071130162056.24352.qmail@sourceware.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	teigland at sourceware.org	2007-11-30 16:20:56

Modified files:
	group/gfs_controld: plock.c 

Log message:
	change some log messages

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/gfs_controld/plock.c.diff?cvsroot=cluster&r1=1.35&r2=1.36

--- cluster/group/gfs_controld/plock.c	2007/11/29 21:27:58	1.35
+++ cluster/group/gfs_controld/plock.c	2007/11/30 16:20:55	1.36
@@ -971,6 +971,9 @@
 	   - A sends drop, B sends plock, receive drop, receive plock.
 	   This is addressed above.
 
+	   - A sends drop, B sends plock, receive drop, B reads plock
+	   and sends own, receive plock, on B we find owner of -1.
+
 	   - A sends drop, B sends two plocks, receive drop, receive plocks.
 	   Receiving the first plock is the previous case, receiving the
 	   second plock will find r with owner of -1.
@@ -983,23 +986,29 @@
 	   last case below; receiving a plock from ourself and finding
 	   we're the owner of r. */
 
-	/* may want to supress this if some of them are common enough */
-	if (r->owner)
-		log_error("receive_plock from %d r %llx owner %d", from,
-			  (unsigned long long)info.number, r->owner);
-
 	if (!r->owner) {
 		__receive_plock(mg, &info, from, r);
 
 	} else if (r->owner == -1) {
+		log_debug("receive_plock from %d r %llx owner %d", from,
+			  (unsigned long long)info.number, r->owner);
+
 		if (from == our_nodeid)
 			save_pending_plock(mg, r, &info);
 
 	} else if (r->owner != our_nodeid) {
+		/* might happen, if frequent change to log_debug */
+		log_error("receive_plock from %d r %llx owner %d", from,
+			  (unsigned long long)info.number, r->owner);
+
 		if (from == our_nodeid)
 			save_pending_plock(mg, r, &info);
 
 	} else if (r->owner == our_nodeid) {
+		/* might happen, if frequent change to log_debug */
+		log_error("receive_plock from %d r %llx owner %d", from,
+			  (unsigned long long)info.number, r->owner);
+
 		if (from == our_nodeid)
 			__receive_plock(mg, &info, from, r);
 	}