From: fabbione@sourceware.org <fabbione@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cman/daemon ais.c
Date: 30 Dec 2007 09:30:15 -0000 [thread overview]
Message-ID: <20071230093015.15029.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: fabbione at sourceware.org 2007-12-30 09:30:15
Modified files:
cman/daemon : ais.c
Log message:
Fix error reporting to aisexec.
aisexec expects an error_string string set by config_read if config_read fails.
The lack of error_string is not checked by aisexec that will segfault.
Set error_string properly and clean up the old errorstring that is not used.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/daemon/ais.c.diff?cvsroot=cluster&r1=1.56&r2=1.57
--- cluster/cman/daemon/ais.c 2007/12/13 13:39:58 1.56
+++ cluster/cman/daemon/ais.c 2007/12/30 09:30:15 1.57
@@ -62,7 +62,6 @@
int num_ais_nodes;
static int config_run;
-static char errorstring[512];
static int startup_pipe;
static unsigned int debug_mask;
static int first_trans = 1;
@@ -231,7 +230,7 @@
if (error)
{
write_cman_pipe("Error reading config from CCS");
- sprintf(errorstring, "Error reading config from CCS");
+ *error_string = "Error reading config from CCS";
return -1;
}
next reply other threads:[~2007-12-30 9:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 9:30 fabbione [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-02 11:05 [Cluster-devel] cluster/cman/daemon ais.c pcaulfield
2007-12-31 5:15 fabbione
2007-12-13 13:39 pcaulfield
2007-11-01 14:06 pcaulfield
2007-10-15 14:48 pcaulfield
2007-10-01 12:36 pcaulfield
2007-05-10 9:05 pcaulfield
2007-05-09 16:16 pcaulfield
2007-05-03 12:18 pcaulfield
2007-05-04 2:30 ` Steven Dake
2007-05-04 0:07 ` Steven Dake
2006-12-18 9:49 pcaulfield
2006-12-18 9:48 pcaulfield
2006-12-18 9:37 pcaulfield
2006-11-09 13:51 pcaulfield
2006-11-09 13:50 pcaulfield
2006-11-09 13:10 pcaulfield
2006-10-31 17:27 pcaulfield
2006-10-31 9:28 pcaulfield
2006-09-25 11:38 pcaulfield
2006-08-11 7:09 pcaulfield
2006-08-10 19:45 rpeterso
2006-08-09 9:46 pcaulfield
2006-07-19 8:33 pcaulfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230093015.15029.qmail@sourceware.org \
--to=fabbione@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).