From: pcaulfield@sourceware.org <pcaulfield@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cman/daemon commands.c
Date: 2 Jan 2008 09:27:13 -0000 [thread overview]
Message-ID: <20080102092713.6511.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: pcaulfield at sourceware.org 2008-01-02 09:27:12
Modified files:
cman/daemon : commands.c
Log message:
totempg_ifaces_get() always copies INTERFACE_MAX addresses
so make sure we alloate enough space for them all.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/daemon/commands.c.diff?cvsroot=cluster&r1=1.77&r2=1.78
--- cluster/cman/daemon/commands.c 2007/12/05 14:28:58 1.77
+++ cluster/cman/daemon/commands.c 2008/01/02 09:27:12 1.78
@@ -345,7 +345,8 @@
int addrlen=0;
unsigned int numaddrs=1;
char **status;
- struct totem_ip_address node_ifs[num_interfaces];
+ struct totem_ip_address node_ifs[INTERFACE_MAX];
+ /* totempg_ifaces_get always copies INTERFACE_MAX addresses */
strcpy(unode->name, node->name);
unode->jointime = node->join_time;
@@ -361,7 +362,6 @@
must ask for them */
totempg_ifaces_get(node->node_id, node_ifs, &status, &numaddrs);
-
totemip_totemip_to_sockaddr_convert(&node_ifs[0], 0, &ss, &addrlen);
memcpy(unode->addr, &ss, addrlen);
unode->addrlen = addrlen;
@@ -1173,7 +1173,7 @@
int i;
char *outbuf = *retbuf + offset;
struct cl_get_node_addrs *addrs = (struct cl_get_node_addrs *)outbuf;
- struct totem_ip_address node_ifs[num_interfaces];
+ struct totem_ip_address node_ifs[INTERFACE_MAX]; /* totempg_ifaces_get always copies INTERFACE_MAX addresses */
struct cluster_node *node;
char **status;
next reply other threads:[~2008-01-02 9:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 9:27 pcaulfield [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-02-04 10:54 [Cluster-devel] cluster/cman/daemon commands.c pcaulfield
2008-01-03 16:36 pcaulfield
2008-01-03 16:35 pcaulfield
2008-01-03 20:40 ` Fabio M. Di Nitto
2008-01-03 6:48 fabbione
2008-01-02 16:23 pcaulfield
2008-01-02 10:02 pcaulfield
2007-11-26 17:03 lhh
2007-11-20 9:21 pcaulfield
2007-11-20 9:02 pcaulfield
2007-09-27 9:05 pcaulfield
2007-09-27 9:01 pcaulfield
2007-09-17 13:35 pcaulfield
2007-09-07 12:17 pcaulfield
2007-08-22 7:05 pcaulfield
2007-01-17 15:02 pcaulfield
2007-01-17 15:02 pcaulfield
2007-01-17 11:01 pcaulfield
2007-01-17 14:50 ` Robert Peterson
2007-01-17 11:00 pcaulfield
2007-01-16 16:31 pcaulfield
2007-01-16 9:57 pcaulfield
2007-01-16 9:54 pcaulfield
2007-01-09 13:32 pcaulfield
2007-01-09 13:31 pcaulfield
2007-01-08 10:16 pcaulfield
2007-01-08 10:16 pcaulfield
2006-12-13 14:20 pcaulfield
2006-12-13 13:39 pcaulfield
2006-12-13 13:38 pcaulfield
2006-11-06 10:06 pcaulfield
2006-10-16 14:10 pcaulfield
2006-10-10 15:14 pcaulfield
2006-09-12 12:45 pcaulfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080102092713.6511.qmail@sourceware.org \
--to=pcaulfield@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).