From mboxrd@z Thu Jan 1 00:00:00 1970 From: wcheng@sourceware.org Date: 2 Jan 2008 15:07:07 -0000 Subject: [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c Message-ID: <20080102150707.5399.qmail@sourceware.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit CVSROOT: /cvs/cluster Module name: cluster Branch: RHEL5 Changes by: wcheng at sourceware.org 2008-01-02 15:07:07 Modified files: gfs-kernel/src/gfs: ops_export.c Log message: Dmitry Monakhov from OpenVZ linux kernel team reports about wrong locking order in gfs_get_parent(). Patch submitted by Vasily Averin (vvs at sw.ru) under Red Hat bugzilla 400651 Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.8.2.3&r2=1.8.2.4 --- cluster/gfs-kernel/src/gfs/ops_export.c 2007/06/05 05:43:14 1.8.2.3 +++ cluster/gfs-kernel/src/gfs/ops_export.c 2008/01/02 15:07:06 1.8.2.4 @@ -254,12 +254,12 @@ ip = get_gl2ip(i_gh.gh_gl); - gfs_glock_dq_uninit(&d_gh); - gfs_glock_dq_uninit(&i_gh); - inode = gfs_iget(ip, CREATE); gfs_inode_put(ip); + gfs_glock_dq_uninit(&d_gh); + gfs_glock_dq_uninit(&i_gh); + if (!inode) return ERR_PTR(-ENOMEM);