cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: wcheng@sourceware.org <wcheng@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/gfs rgrp.c
Date: 2 Jan 2008 18:45:07 -0000	[thread overview]
Message-ID: <20080102184507.20006.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL5
Changes by:	wcheng at sourceware.org	2008-01-02 18:45:07

Modified files:
	gfs-kernel/src/gfs: rgrp.c 

Log message:
	Bugzilla 227892:
	
	* Warn people about the RG corruption and request a gfs_fsck
	* Upon error detection, perform a minimum error data collection

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/rgrp.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.19.2.1&r2=1.19.2.2

--- cluster/gfs-kernel/src/gfs/rgrp.c	2007/06/19 14:47:07	1.19.2.1
+++ cluster/gfs-kernel/src/gfs/rgrp.c	2008/01/02 18:45:07	1.19.2.2
@@ -1455,8 +1455,13 @@
 		goal = 0;
 	}
 
-	if (gfs_assert_withdraw(rgd->rd_sbd, x <= length))
-		blk = 0;
+	if (unlikely(x > length)) {
+		printk("GFS error: possible RG corruption\n");
+		printk("    please run gfs_fsck after withdraw\n");
+		dump_stack();
+		if (gfs_assert_withdraw(rgd->rd_sbd, x <= length))
+			blk = 0;
+	} 
 
 	/* Attach bitmap buffer to trans, modify bits to do block alloc */
 	gfs_trans_add_bh(rgd->rd_gl, rgd->rd_bh[buf]);



             reply	other threads:[~2008-01-02 18:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 18:45 wcheng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-02 19:17 [Cluster-devel] cluster/gfs-kernel/src/gfs rgrp.c wcheng
2008-01-30  6:57 fabbione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080102184507.20006.qmail@sourceware.org \
    --to=wcheng@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).