From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/dlm group.c
Date: 14 Jan 2008 15:29:43 -0000 [thread overview]
Message-ID: <20080114152943.23907.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: teigland at sourceware.org 2008-01-14 15:29:43
Modified files:
gfs-kernel/src/dlm: group.c
Log message:
bz 353311
Disassembling the module, the oops appears to be when dereferencing
dlm->mg_nodes. I see one place where the mg_nodes list is modified
without holding mg_nodes_lock, and that's in release_mg_nodes().
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/dlm/group.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.8.2.2&r2=1.8.2.3
--- cluster/gfs-kernel/src/dlm/Attic/group.c 2005/06/29 07:28:21 1.8.2.2
+++ cluster/gfs-kernel/src/dlm/Attic/group.c 2008/01/14 15:29:42 1.8.2.3
@@ -751,7 +751,9 @@
kcl_unregister_service(dlm->mg_local_id);
release_jid(dlm);
+ down(&dlm->mg_nodes_lock);
release_mg_nodes(dlm);
+ up(&dlm->mg_nodes_lock);
}
/*
reply other threads:[~2008-01-14 15:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114152943.23907.qmail@sourceware.org \
--to=teigland@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox