From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cmirror/src functions.c local.c
Date: 15 Jan 2008 22:01:19 -0000 [thread overview]
Message-ID: <20080115220119.26794.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: jbrassow at sourceware.org 2008-01-15 22:01:18
Modified files:
cmirror/src : functions.c local.c
Log message:
- a 'return' instead of a 'goto' was skipping over some key initialization,
causing core logged cluster mirrors not to work
Bug #385001
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror/src/functions.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.1.2.7&r2=1.1.2.8
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror/src/local.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.1.2.6&r2=1.1.2.7
--- cluster/cmirror/src/Attic/functions.c 2008/01/14 22:52:17 1.1.2.7
+++ cluster/cmirror/src/Attic/functions.c 2008/01/15 22:01:18 1.1.2.8
@@ -724,7 +724,7 @@
return -EINVAL;
if (lc->disk_fd == -1)
- return 0;
+ goto out;
switch (lc->resume_override) {
case 1000:
--- cluster/cmirror/src/Attic/local.c 2008/01/14 22:52:17 1.1.2.6
+++ cluster/cmirror/src/Attic/local.c 2008/01/15 22:01:18 1.1.2.7
@@ -151,8 +151,8 @@
if (r)
return r;
- LOG_DBG("Request from kernel recieved [%s/%llu]",
- RQ_TYPE(tfr->request_type), tfr->seq);
+ LOG_DBG("Request from kernel recieved [%s/%s/%llu]",
+ RQ_TYPE(tfr->request_type), SHORT_UUID(tfr->uuid), tfr->seq);
switch (tfr->request_type) {
case DM_CLOG_CTR:
case DM_CLOG_DTR:
reply other threads:[~2008-01-15 22:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115220119.26794.qmail@sourceware.org \
--to=jbrassow@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox