cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/gfs_controld plock.c
Date: 21 Jan 2008 20:19:09 -0000	[thread overview]
Message-ID: <20080121201909.22239.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL51
Changes by:	teigland at sourceware.org	2008-01-21 20:19:08

Modified files:
	group/gfs_controld: plock.c 

Log message:
	bz 429546
	
	Fix an alignment problem with ppc64.  Things work if we do the
	byte-swapping on the original structure and then copy it into the
	final buffer, instead of copying first and then trying to do the
	byte-swapping at an offset within the send buffer.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/gfs_controld/plock.c.diff?cvsroot=cluster&only_with_tag=RHEL51&r1=1.25.2.6&r2=1.25.2.6.2.1

--- cluster/group/gfs_controld/plock.c	2007/06/08 21:31:56	1.25.2.6
+++ cluster/group/gfs_controld/plock.c	2008/01/21 20:19:08	1.25.2.6.2.1
@@ -399,15 +399,14 @@
 
 	info.nodeid = our_nodeid;
 
+	info_bswap_out(&info);
+
 	hd = (struct gdlm_header *)buf;
 	hd->type = MSG_PLOCK;
 	hd->nodeid = our_nodeid;
 	hd->to_nodeid = 0;
 	memcpy(buf + sizeof(struct gdlm_header), &info, sizeof(info));
 
-	info_bswap_out((struct gdlm_plock_info *) buf +
-						  sizeof(struct gdlm_header));
-
 	rv = send_group_message(mg, len, buf);
 
 	free(buf);



             reply	other threads:[~2008-01-21 20:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 20:19 teigland [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-21 20:21 [Cluster-devel] cluster/group/gfs_controld plock.c teigland
2008-01-21 20:17 teigland
2007-11-30 16:20 teigland
2007-11-29 21:27 teigland
2007-06-08 21:31 teigland
2007-06-08 21:30 teigland
2006-11-20 21:29 teigland
2006-11-20 21:29 teigland
2006-11-20 21:28 teigland
2006-11-20 18:13 teigland
2006-11-20 18:12 teigland
2006-11-20 18:10 teigland
2006-11-03 15:33 teigland
2006-10-09 21:51 teigland
2006-08-17 19:39 teigland
2006-08-16 19:30 teigland
2006-08-16 17:05 teigland
2006-08-15 22:21 rpeterso
2006-08-14 20:15 teigland
2006-08-08 19:37 teigland
2006-08-08 18:43 teigland
2006-08-02 19:23 teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080121201909.22239.qmail@sourceware.org \
    --to=teigland@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).