cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [Cluster-devel] conga/luci/cluster validate_fence.js
@ 2006-10-04 17:25 kupcevic
  0 siblings, 0 replies; 6+ messages in thread
From: kupcevic @ 2006-10-04 17:25 UTC (permalink / raw)
  To: cluster-devel.redhat.com

CVSROOT:	/cvs/cluster
Module name:	conga
Changes by:	kupcevic at sourceware.org	2006-10-04 17:25:20

Added files:
	luci/cluster   : validate_fence.js 

Log message:
	missing file, remove if not needed any more

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&r1=NONE&r2=1.1

/cvs/cluster/conga/luci/cluster/validate_fence.js,v  -->  standard output
revision 1.1
--- conga/luci/cluster/validate_fence.js
+++ -	2006-10-04 17:25:21.448409000 +0000
@@ -0,0 +1,48 @@
+function validate_fence_apc(form) {
+	return (0);
+}
+
+function validate_fence_wti(form) {
+	return (0);
+}
+
+function validate_fence_rsa(form) {
+	return (0);
+}
+
+function validate_fence_ilo(form) {
+	return (0);
+}
+
+function validate_fence_drac(form) {
+	return (0);
+}
+
+function validate_fence_ipmilan(form) {
+	return (0);
+}
+
+var fence_validator = new Object();
+fence_validator['apc'] = validate_fence_apc;
+fence_validator['wti'] = validate_fence_wti;
+fence_validator['rsa'] = validate_fence_rsa;
+fence_validator['ilo'] = validate_fence_ilo;
+fence_validator['drac'] = validate_fence_drac;
+fence_validator['ipmilan'] = validate_fence_ipmilan;
+
+function validate_fence_common(form) {
+	return (null);
+}
+
+function validate_fence(form) {
+	if (!form || !form.fence_type || !form.fence_type.value)
+		return (-1);
+	var errors = validate_fence_common(form);
+	var f = fence_validator[form.fence_type.value];
+	if (!f)
+		return (-1);
+	var err = f(form);
+	if (err)
+		errors = errors.concat(err);
+	return (errors);
+}



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Cluster-devel] conga/luci/cluster validate_fence.js
@ 2007-02-16 23:25 rmccabe
  0 siblings, 0 replies; 6+ messages in thread
From: rmccabe @ 2007-02-16 23:25 UTC (permalink / raw)
  To: cluster-devel.redhat.com

CVSROOT:	/cvs/cluster
Module name:	conga
Changes by:	rmccabe at sourceware.org	2007-02-16 23:25:27

Modified files:
	luci/cluster   : validate_fence.js 

Log message:
	Fix a front-end fence instance validation bug.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&r1=1.5&r2=1.6

--- conga/luci/cluster/validate_fence.js	2007/02/12 23:26:54	1.5
+++ conga/luci/cluster/validate_fence.js	2007/02/16 23:25:27	1.6
@@ -146,9 +146,11 @@
 
 	for (var i = 0 ; i < fields.length ; i++) {
 		var field_name = fields[i];
-		var err = field_validator[field_name](form, form[field_name]);
-		if (err)
-			errors = errors.concat(err);
+		if (form[field_name]) {
+			var err = field_validator[field_name](form, form[field_name]);
+			if (err)
+				errors = errors.concat(err);
+		}
 	}
 
 	return (errors);
@@ -183,9 +185,11 @@
 
 	for (var i = 0 ; i < fields.length ; i++) {
 		var field_name = fields[i];
-		var err = field_validator[field_name](form[field_name]);
-		if (err)
-			errors = errors.concat(err);
+		if (form[field_name]) {
+			var err = field_validator[field_name](form, form[field_name]);
+			if (err)
+				errors = errors.concat(err);
+		}
 	}
 
 	return (errors);



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Cluster-devel] conga/luci/cluster validate_fence.js
@ 2007-02-16 23:26 rmccabe
  0 siblings, 0 replies; 6+ messages in thread
From: rmccabe @ 2007-02-16 23:26 UTC (permalink / raw)
  To: cluster-devel.redhat.com

CVSROOT:	/cvs/cluster
Module name:	conga
Branch: 	RHEL4
Changes by:	rmccabe at sourceware.org	2007-02-16 23:25:59

Modified files:
	luci/cluster   : validate_fence.js 

Log message:
	Fix a front-end fence instance validation bug.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.3.2.2&r2=1.3.2.3

--- conga/luci/cluster/validate_fence.js	2007/02/12 23:28:15	1.3.2.2
+++ conga/luci/cluster/validate_fence.js	2007/02/16 23:25:59	1.3.2.3
@@ -146,9 +146,11 @@
 
 	for (var i = 0 ; i < fields.length ; i++) {
 		var field_name = fields[i];
-		var err = field_validator[field_name](form, form[field_name]);
-		if (err)
-			errors = errors.concat(err);
+		if (form[field_name]) {
+			var err = field_validator[field_name](form, form[field_name]);
+			if (err)
+				errors = errors.concat(err);
+		}
 	}
 
 	return (errors);
@@ -183,9 +185,11 @@
 
 	for (var i = 0 ; i < fields.length ; i++) {
 		var field_name = fields[i];
-		var err = field_validator[field_name](form[field_name]);
-		if (err)
-			errors = errors.concat(err);
+		if (form[field_name]) {
+			var err = field_validator[field_name](form, form[field_name]);
+			if (err)
+				errors = errors.concat(err);
+		}
 	}
 
 	return (errors);



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Cluster-devel] conga/luci/cluster validate_fence.js
@ 2007-07-23 15:09 rmccabe
  0 siblings, 0 replies; 6+ messages in thread
From: rmccabe @ 2007-07-23 15:09 UTC (permalink / raw)
  To: cluster-devel.redhat.com

CVSROOT:	/cvs/cluster
Module name:	conga
Branch: 	RHEL5
Changes by:	rmccabe at sourceware.org	2007-07-23 15:09:17

Modified files:
	luci/cluster   : validate_fence.js 

Log message:
	Fix code that could cause javascript errors when adding fence devices for the first time with gecko-based browsers (firefox/mozilla/etc).

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.1.2.3&r2=1.1.2.4

--- conga/luci/cluster/validate_fence.js	2007/07/12 04:41:39	1.1.2.3
+++ conga/luci/cluster/validate_fence.js	2007/07/23 15:09:17	1.1.2.4
@@ -258,7 +258,15 @@
 		for (var j = 0 ; j < select_elem.length ; j++) {
 			temp += '<input type="text" name="' + escapeXML(select_elem[j].name) + '" value="' + escapeXML(select_elem[j].options[select_elem[j].options.selectedIndex].value) + '" />';
 		}
-		form_xml += '<form id="' + escapeXML(form[i].attributes['name'].value) + '">' + temp + '</form>';
+		var form_name = '';
+
+		try {
+			form_name = form[i].attributes['name'].value;
+		} catch (e) {
+			form_name = form[i].getAttribute('name');
+		}
+
+		form_xml += '<form id="' + escapeXML(form_name) + '">' + temp + '</form>';
 	}
 
 	master_form.fence_xml.value = '<formlist>' + form_xml + '</formlist>';



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Cluster-devel] conga/luci/cluster validate_fence.js
@ 2007-07-26  4:14 rmccabe
  0 siblings, 0 replies; 6+ messages in thread
From: rmccabe @ 2007-07-26  4:14 UTC (permalink / raw)
  To: cluster-devel.redhat.com

CVSROOT:	/cvs/cluster
Module name:	conga
Branch: 	RHEL5
Changes by:	rmccabe at sourceware.org	2007-07-26 04:14:15

Modified files:
	luci/cluster   : validate_fence.js 

Log message:
	Fix the frontend to allow spaces as a fence password (part of the fix for 249097)

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.1.2.4&r2=1.1.2.5

--- conga/luci/cluster/validate_fence.js	2007/07/23 15:09:17	1.1.2.4
+++ conga/luci/cluster/validate_fence.js	2007/07/26 04:14:14	1.1.2.5
@@ -51,12 +51,22 @@
 }
 
 function validate_field_passwd(form, form_elem) {
+	var errors = [];
 	if (form_elem.disabled) {
 		clr_form_err(form_elem);
 		return (null);
 	}
 
-	var errors = validate_field_str(form, form_elem);
+	if (!form_elem || !form_elem.value) {
+		if (!form_elem) {
+			errors.push('No value was given for this field.');
+		} else {
+			set_form_err(form_elem);
+			errors.push(form_elem.name + ' values must not be empty.');
+		}
+		return (errors);
+	}
+
 	if (errors && errors.length > 0 && form.passwd_script && !str_is_blank(form.passwd_script.value))
 	{
 		clr_form_err(form_elem);



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Cluster-devel] conga/luci/cluster validate_fence.js
@ 2008-04-23 17:23 rmccabe
  0 siblings, 0 replies; 6+ messages in thread
From: rmccabe @ 2008-04-23 17:23 UTC (permalink / raw)
  To: cluster-devel.redhat.com

CVSROOT:	/cvs/cluster
Module name:	conga
Branch: 	RHEL4
Changes by:	rmccabe at sourceware.org	2008-04-23 17:23:00

Modified files:
	luci/cluster   : validate_fence.js 

Log message:
	Fix typo

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.3.2.7&r2=1.3.2.8

--- conga/luci/cluster/validate_fence.js	2008/04/21 18:15:17	1.3.2.7
+++ conga/luci/cluster/validate_fence.js	2008/04/23 17:22:59	1.3.2.8
@@ -13,7 +13,7 @@
 fence_inst_validator['brocade'] = [ 'port' ];
 fence_inst_validator['bullpap'] = [ 'domain' ];
 fence_inst_validator['egenera'] = [ 'lpan', 'pserver' ];
-fence_inst_validator['gndb'] = [ 'ipaddress' ];
+fence_inst_validator['gnbd'] = [ 'ipaddress' ];
 fence_inst_validator['mcdata'] = [ 'port' ];
 fence_inst_validator['sanbox2'] = [ 'port' ];
 fence_inst_validator['scsi'] = [ 'nodename' ];



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-04-23 17:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-23 17:23 [Cluster-devel] conga/luci/cluster validate_fence.js rmccabe
  -- strict thread matches above, loose matches on Subject: below --
2007-07-26  4:14 rmccabe
2007-07-23 15:09 rmccabe
2007-02-16 23:26 rmccabe
2007-02-16 23:25 rmccabe
2006-10-04 17:25 kupcevic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).