From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] checking NULL pointer in device_write of dlm-control
Date: Wed, 28 May 2008 09:26:38 -0500 [thread overview]
Message-ID: <20080528142638.GA20154@redhat.com> (raw)
In-Reply-To: <20080528.144510.108902725.yamato@redhat.com>
On Wed, May 28, 2008 at 02:45:10PM +0900, Masatake YAMATO wrote:
> Hi,
>
> I found a way to let linux dereference NULL pointer
> in gfs2-2.6-nmw/fs/dlm/user.c.
>
> If `device_write' method is called via "dlm-control",
> file->private_data is NULL. (See ctl_device_open() in
> user.c. ) Through proc->flags is read:
>
> if ((kbuf->cmd == DLM_USER_LOCK || kbuf->cmd == DLM_USER_UNLOCK) &&
> test_bit(DLM_PROC_FLAGS_CLOSING, &proc->flags))
> return -EINVAL;
Thanks for the patch, I'll push it out shortly.
Dave
next prev parent reply other threads:[~2008-05-28 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 5:45 [Cluster-devel] [PATCH] checking NULL pointer in device_write of dlm-control Masatake YAMATO
2008-05-28 14:26 ` David Teigland [this message]
2008-06-20 3:29 ` [Cluster-devel] [PATCH] set NULL to sock field of connection if listen failed Masatake YAMATO
2008-06-23 2:22 ` [Cluster-devel] " Masatake YAMATO
2008-06-23 3:30 ` [Cluster-devel] [PATCH] release sock in tcp_connect_to_sock of dlm if dlm_nodeid_to_addr returns error Masatake YAMATO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080528142638.GA20154@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).