From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Teigland <teigland@redhat.com>
Date: Wed, 25 Jun 2008 09:43:44 -0500
Subject: [Cluster-devel] logsys in fenced
In-Reply-To: <20080625042547.24195.qmail@sourceware.org>
References: <20080625042547.24195.qmail@sourceware.org>
Message-ID: <20080625144343.GA18958@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

> commit 95a5c6b13294742956b13070ebc4f4513278255f
> Author: Fabio M. Di Nitto <fdinitto@redhat.com>
> Date:   Wed Jun 25 06:24:11 2008 +0200
> 
>     [FENCE] fenced: separate concept of fork and debugging
>     
>     allow fenced to fork when debugging is set from the configuration
>     or the system will hang at boot.
>     
>     Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
> 
> commit da704715c606c9c01637ae53d79f8dec6a8b0389
> Author: Fabio M. Di Nitto <fdinitto@redhat.com>
> Date:   Wed Jun 25 05:19:35 2008 +0200
> 
>     [FENCE] Allow fenced to configure logsys
>     
>     Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
> 
> commit 18e085596bb8844f74689a92662f2e5e9166836b
> Author: Fabio M. Di Nitto <fdinitto@redhat.com>
> Date:   Wed Jun 25 04:49:41 2008 +0200
> 
>     [FENCE] Move logsys configuration calls where they belong
>     
>     Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
> 
> commit c54c56c5a09f98547ceda3bc5fa9afa28b354480
> Author: Fabio M. Di Nitto <fdinitto@redhat.com>
> Date:   Wed Jun 25 04:23:20 2008 +0200
> 
>     [FENCE] Make fenced ready to load logsys config
>     
>     Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
> 
> commit cf4c7ebac813b0b607acf6cf74bbdddfc8cfb12a
> Author: Fabio M. Di Nitto <fdinitto@redhat.com>
> Date:   Tue Jun 24 14:34:35 2008 +0200
> 
>     [FENCE] Start porting fenced to logsys
>     
>     Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

OK, I'm fine with replacing the use of syslog with logsys, but this goes
beyond that.  Here are the problems I see:


. Leave log_debug() unchanged, and leave the meaning/effect of -D unchanged.
  syslog/logsys are about logging to files.  The debug "logging" I use is
  about logging to either an in-memory buffer or to stderr; syslog/logsys
  are not relevant to that.


. Change log_error() to use logsys instead of syslog, i.e. don't change
  the existing log_error() call sites.

  #define log_error(fmt, args...) \
  do { \
	log_debug(fmt, ##args); \
  -	syslog(LOG_ERR, fmt, ##args); \
  + 	log_printf(LOG_ERR, fmt, ##args); \
  } while (0)


. Finally, one gripe with logsys itself.  Here's syslog initialization:

  openlog("fenced", LOG_PID, LOG_DAEMON);

  Compare with logsys initialization:

  LOGSYS_DECLARE_SYSTEM (NULL,
  	LOG_MODE_OUTPUT_STDERR | LOG_MODE_OUTPUT_SYSLOG_THREADED | 
	LOG_MODE_OUTPUT_FILE | LOG_MODE_BUFFER_BEFORE_CONFIG,
	LOGDIR "/fenced.log",
	SYSLOGFACILITY);
  LOGSYS_DECLARE_SUBSYS ("FENCED", LOG_LEVEL_INFO);

  ...

  logsys_config_mode_set(LOG_MODE_OUTPUT_STDERR |
	LOG_MODE_OUTPUT_SYSLOG_THREADED | LOG_MODE_OUTPUT_FILE | 
	LOG_MODE_FLUSH_AFTER_CONFIG);

  ... and at the start of every other file:

  LOGSYS_DECLARE_SUBSYS ("FENCED", LOG_LEVEL_INFO);

  This really gets out of hand.  I'd like to see the initialization wrapped
  into a single function call, and the macros at the start of every file
  unnecessary.