From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [PATCH] dlm: fix uninitialized variable for search_rsb_list callers
Date: Mon, 30 Jun 2008 12:01:58 -0500 [thread overview]
Message-ID: <20080630170157.GB31662@redhat.com> (raw)
In-Reply-To: <1214845154-4978-1-git-send-email-bhalevy@panasas.com>
On Mon, Jun 30, 2008 at 07:59:14PM +0300, Benny Halevy wrote:
> gcc 4.3.0 correctly emits the following warning.
> search_rsb_list does not *r_ret if no dlm_rsb is found
> and _search_rsb may pass the uninitialized value upstream
> on the error path when both calls to search_rsb_list
> return non-zero error.
>
> The fix sets *r_ret to NULL on search_rsb_list's not-found path.
Added to dlm.git.
Thanks, Dave
parent reply other threads:[~2008-06-30 17:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1214845154-4978-1-git-send-email-bhalevy@panasas.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630170157.GB31662@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).