From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Mon, 30 Jun 2008 12:01:58 -0500 Subject: [Cluster-devel] Re: [PATCH] dlm: fix uninitialized variable for search_rsb_list callers In-Reply-To: <1214845154-4978-1-git-send-email-bhalevy@panasas.com> References: <1214845154-4978-1-git-send-email-bhalevy@panasas.com> Message-ID: <20080630170157.GB31662@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jun 30, 2008 at 07:59:14PM +0300, Benny Halevy wrote: > gcc 4.3.0 correctly emits the following warning. > search_rsb_list does not *r_ret if no dlm_rsb is found > and _search_rsb may pass the uninitialized value upstream > on the error path when both calls to search_rsb_list > return non-zero error. > > The fix sets *r_ret to NULL on search_rsb_list's not-found path. Added to dlm.git. Thanks, Dave