[Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.05-66-g0dcc5e5

[Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.05-66-g0dcc5e5

[teigland]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Cluster Project".

http://sources.redhat.com/git/gitweb.cgi?p=cluster.git;a=commitdiff;h=0dcc5e557008df4d51aef891ebfb998a34785f04

The branch, master has been updated
       via  0dcc5e557008df4d51aef891ebfb998a34785f04 (commit)
      from  98c12372432e994a5c8310d16a6dbb9f9295043b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0dcc5e557008df4d51aef891ebfb998a34785f04
Author: David Teigland <teigland@redhat.com>
Date:   Fri Jul 11 12:04:26 2008 -0500

    fenced: tune logsys settings
    
    put errors in fenced.log (in addition to syslog) by default
    keep debug out of syslog by default (commented out pending openais commit)
    
    Signed-off-by: David Teigland <teigland@redhat.com>

-----------------------------------------------------------------------

Summary of changes:
 fence/fenced/logging.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/fence/fenced/logging.c b/fence/fenced/logging.c
index 485810d..1cfb03e 100644
--- a/fence/fenced/logging.c
+++ b/fence/fenced/logging.c
@@ -1,6 +1,12 @@
 #include "fd.h"
 
-#define DEFAULT_MODE		LOG_MODE_OUTPUT_SYSLOG_THREADED
+/* default: errors go to syslog (/var/log/messages) and fenced.log
+   logging/debug=on: errors continue going to syslog (/var/log/messages)
+   and fenced.log, debug messages are added to fenced.log. */
+
+#define DEFAULT_MODE		LOG_MODE_OUTPUT_SYSLOG_THREADED | \
+				LOG_MODE_NOSUBSYS | \
+				LOG_MODE_OUTPUT_FILE /* | LOG_MODE_NO_DEBUG_SYSLOG */
 #define DEFAULT_FACILITY	SYSLOGFACILITY /* cluster config setting */
 #define DEFAULT_PRIORITY	SYSLOGLEVEL /* cluster config setting */
 #define DEFAULT_FILE		LOGDIR "/fenced.log"


hooks/post-receive
--
Cluster Project

[Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.05-66-g0dcc5e5

[Fabio M. Di Nitto]

On Fri, 11 Jul 2008, teigland at sourceware.org wrote:

> - Log -----------------------------------------------------------------
> commit 0dcc5e557008df4d51aef891ebfb998a34785f04
> Author: David Teigland <teigland@redhat.com>
> Date:   Fri Jul 11 12:04:26 2008 -0500
>
>    fenced: tune logsys settings
>
>    put errors in fenced.log (in addition to syslog) by default
>    keep debug out of syslog by default (commented out pending openais commit)
>
>    Signed-off-by: David Teigland <teigland@redhat.com>
>
> -----------------------------------------------------------------------
>
> Summary of changes:
> fence/fenced/logging.c |    8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/fence/fenced/logging.c b/fence/fenced/logging.c
> index 485810d..1cfb03e 100644
> --- a/fence/fenced/logging.c
> +++ b/fence/fenced/logging.c
> @@ -1,6 +1,12 @@
> #include "fd.h"
>
> -#define DEFAULT_MODE		LOG_MODE_OUTPUT_SYSLOG_THREADED
> +/* default: errors go to syslog (/var/log/messages) and fenced.log
> +   logging/debug=on: errors continue going to syslog (/var/log/messages)
> +   and fenced.log, debug messages are added to fenced.log. */
> +
> +#define DEFAULT_MODE		LOG_MODE_OUTPUT_SYSLOG_THREADED | \
> +				LOG_MODE_NOSUBSYS | \

isn't LOG_MODE_NOSUBSYS going to remove [FENCED] from the output?

How are we going to recognize our messages in syslog?

My understading was that NOSUBSYS should be used to print to stderr only

> +				LOG_MODE_OUTPUT_FILE /* | LOG_MODE_NO_DEBUG_SYSLOG */

LOG_MODE_FILTER_DEBUG_FROM_SYSLOG <- after Steven/Chrissie review.

Fabio

--
I'm going to make him an offer he can't refuse.

[Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.05-66-g0dcc5e5

[Fabio M. Di Nitto]

On Mon, 14 Jul 2008, Fabio M. Di Nitto wrote:

>> +				LOG_MODE_OUTPUT_FILE /* | 
>> LOG_MODE_NO_DEBUG_SYSLOG */
>
> LOG_MODE_FILTER_DEBUG_FROM_SYSLOG <- after Steven/Chrissie review.

This now in openais trunk if you want to use it.

Fabio

--
I'm going to make him an offer he can't refuse.

[Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.05-66-g0dcc5e5

[David Teigland]

On Mon, Jul 14, 2008 at 09:57:37AM +0200, Fabio M. Di Nitto wrote:
> >+#define DEFAULT_MODE		LOG_MODE_OUTPUT_SYSLOG_THREADED | \
> >+				LOG_MODE_NOSUBSYS | \
> 
> isn't LOG_MODE_NOSUBSYS going to remove [FENCED] from the output?
> 
> How are we going to recognize our messages in syslog?
> 
> My understading was that NOSUBSYS should be used to print to stderr only

I added the flag after noticing that syslog already prefixes it, e.g.

Jul 11 13:30:56 bull-01 fenced[4214]: [fenced] cluster is down, exiting

But the real reason we'd want it, I suspect, is if someone sends all
cluster errors to a common /var/log/cluster/cluster.log, in which case I
think we'd want logsys to add a prefix...

[Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.05-66-g0dcc5e5

[Fabio M. Di Nitto]

On Mon, 14 Jul 2008, David Teigland wrote:

> On Mon, Jul 14, 2008 at 09:57:37AM +0200, Fabio M. Di Nitto wrote:
>>> +#define DEFAULT_MODE		LOG_MODE_OUTPUT_SYSLOG_THREADED | \
>>> +				LOG_MODE_NOSUBSYS | \
>>
>> isn't LOG_MODE_NOSUBSYS going to remove [FENCED] from the output?
>>
>> How are we going to recognize our messages in syslog?
>>
>> My understading was that NOSUBSYS should be used to print to stderr only
>
> I added the flag after noticing that syslog already prefixes it, e.g.
>
> Jul 11 13:30:56 bull-01 fenced[4214]: [fenced] cluster is down, exiting
>
> But the real reason we'd want it, I suspect, is if someone sends all
> cluster errors to a common /var/log/cluster/cluster.log, in which case I
> think we'd want logsys to add a prefix...
>

Maybe the NOSUBSYS implementation in logsys needs a change.

I think we always want SUBSYS when writing to file but we can skip it when 
writing to syslog and stderr. Tho I am not sure it's actually doable 
because the string format is indipendent from the target log.

Lon should know this bit better than me since he implemented it :)

Fabio

--
I'm going to make him an offer he can't refuse.