cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Cluster Project branch, RHEL5, updated. cmirror_1_1_15-163-g613d974
Date: 23 Jul 2008 20:14:38 -0000	[thread overview]
Message-ID: <20080723201438.5981.qmail@sourceware.org> (raw)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Cluster Project".

http://sources.redhat.com/git/gitweb.cgi?p=cluster.git;a=commitdiff;h=613d97438673200c87e4b07e3c4ee659c01acf65

The branch, RHEL5 has been updated
       via  613d97438673200c87e4b07e3c4ee659c01acf65 (commit)
      from  9567fe17bf33eb0008831551b76c7f46c55ba40b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 613d97438673200c87e4b07e3c4ee659c01acf65
Author: Jonathan Brassow <jbrassow@redhat.com>
Date:   Wed Jul 23 15:12:24 2008 -0500

    dm-log-clustered: Fix bug 445456
    
    I was resetting some common memory outside of the
    protection of a lock.

-----------------------------------------------------------------------

Summary of changes:
 cmirror-kernel/src/dm-clog-tfr.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmirror-kernel/src/dm-clog-tfr.c b/cmirror-kernel/src/dm-clog-tfr.c
index 7932f77..7bd30fa 100644
--- a/cmirror-kernel/src/dm-clog-tfr.c
+++ b/cmirror-kernel/src/dm-clog-tfr.c
@@ -173,8 +173,7 @@ int dm_clog_consult_server(const char *uuid, int request_type,
 		DMINFO("Size of tfr exceeds preallocated size");
 		/* FIXME: is kmalloc sufficient if we need this much space? */
 		tfr = kzalloc(data_size + sizeof(*tfr), GFP_NOIO);
-	} else
-		memset(tfr, 0, DM_CLOG_PREALLOCED_SIZE - overhead_size);
+	}
 
 	if (!tfr)
 		return -ENOMEM;
@@ -188,6 +187,7 @@ resend:
 	 */
 	mutex_lock(&_lock);
 
+	memset(tfr, 0, DM_CLOG_PREALLOCED_SIZE - overhead_size);
 	memcpy(tfr->uuid, uuid, DM_UUID_LEN);
 	tfr->seq = seq++;
 	tfr->request_type = request_type;


hooks/post-receive
--
Cluster Project



                 reply	other threads:[~2008-07-23 20:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080723201438.5981.qmail@sourceware.org \
    --to=jbrassow@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).