From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: + fs-dlm-astc-fix-warning.patch added to -mm tree
Date: Mon, 22 Dec 2008 11:06:10 -0600 [thread overview]
Message-ID: <20081222170610.GB13990@redhat.com> (raw)
In-Reply-To: <1229937776.3526.7.camel@localhost.localdomain>
On Mon, Dec 22, 2008 at 09:22:56AM +0000, Steven Whitehouse wrote:
> > Cleans code up.
> >
> > Might be wrong.
> >
> > This is an O(n*n) search :(
> >
> Thats true, but for fairly low values of n in general. Also the dlm
> locking will only be stopped for a lockspace in the case that we are in
> recovery, so that dlm_lock_stopped() is normally false so that this is
> basically iterating down the list, removing each item in turn.
Right, it just takes the first lock off the list, unless the lockspace is
being recovered which is seldom the case. In the recovery case, it just
skips past the locks in the lockspace being recovered. So, I would not
call this O(n*n).
I do like the patch, I hope to get it into the next queue by tomorrow.
Thanks,
Dave
prev parent reply other threads:[~2008-12-22 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812192145.mBJLjwEp014412@imap1.linux-foundation.org>
2008-12-22 9:22 ` [Cluster-devel] Re: + fs-dlm-astc-fix-warning.patch added to -mm tree Steven Whitehouse
2008-12-22 17:06 ` David Teigland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081222170610.GB13990@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).