From: Andrew Price <andy@andrewprice.me.uk>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: gfs2-utils: master - GFS2: fsck.gfs2 sometimes needs to be run twice
Date: Tue, 11 Aug 2009 07:16:57 +0100 [thread overview]
Message-ID: <20090811061657.GA11679@sucs.org> (raw)
In-Reply-To: <20090810163328.4E0011201F3@lists.fedorahosted.org>
Hi Bob,
On Mon, Aug 10, 2009 at 04:33:28PM +0000, Bob Peterson wrote:
> --- a/gfs2/fsck/main.c
> +++ b/gfs2/fsck/main.c
> @@ -191,9 +191,9 @@ static int check_system_inode(struct gfs2_inode *sysinode, const char *filename,
> if(!sysinode || ds.q.block_type != mark) {
Doesn't this ^^^ ...
> log_err( _("Invalid or missing %s system inode.\n"), filename);
> errors_found++;
> - if ((errors_corrected +=
> - query(&opts, _("Create new %s system inode? (y/n) "),
> - filename))) {
> + if (query(&opts, _("Create new %s system inode? (y/n) "),
> + filename)) {
> + errors_corrected++;
> builder(sysinode->i_sbd);
... mean that this ^^^ could be a null pointer dereference bug?
I know it's not part of the patch but it just caught my eye :-)
--
Andrew Price
parent reply other threads:[~2009-08-11 6:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20090810163328.4E0011201F3@lists.fedorahosted.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811061657.GA11679@sucs.org \
--to=andy@andrewprice.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).