From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Tue, 11 Aug 2009 07:16:57 +0100 Subject: [Cluster-devel] Re: gfs2-utils: master - GFS2: fsck.gfs2 sometimes needs to be run twice In-Reply-To: <20090810163328.4E0011201F3@lists.fedorahosted.org> References: <20090810163328.4E0011201F3@lists.fedorahosted.org> Message-ID: <20090811061657.GA11679@sucs.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Bob, On Mon, Aug 10, 2009 at 04:33:28PM +0000, Bob Peterson wrote: > --- a/gfs2/fsck/main.c > +++ b/gfs2/fsck/main.c > @@ -191,9 +191,9 @@ static int check_system_inode(struct gfs2_inode *sysinode, const char *filename, > if(!sysinode || ds.q.block_type != mark) { Doesn't this ^^^ ... > log_err( _("Invalid or missing %s system inode.\n"), filename); > errors_found++; > - if ((errors_corrected += > - query(&opts, _("Create new %s system inode? (y/n) "), > - filename))) { > + if (query(&opts, _("Create new %s system inode? (y/n) "), > + filename)) { > + errors_corrected++; > builder(sysinode->i_sbd); ... mean that this ^^^ could be a null pointer dereference bug? I know it's not part of the patch but it just caught my eye :-) -- Andrew Price