From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Mon, 12 Oct 2009 14:57:04 -0500 Subject: [Cluster-devel] Re: Clean up & fixes for master branch of gfs_controld In-Reply-To: <1255339900.2675.19.camel@localhost.localdomain> References: <1255339900.2675.19.camel@localhost.localdomain> Message-ID: <20091012195704.GB28567@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Oct 12, 2009 at 10:31:40AM +0100, Steven Whitehouse wrote: > Hi, > > The following patch cleans up some old code in gfs_controld and also fixes > one or two issues along the way. After this patch has been applied, > gfs_controld no longer reads from sysfs, but instead gathers all its > information from the uevents. The uevents in question have been in all > recent versions of GFS & GFS2 and so there should be no backward > compatibility issues (even so, this is for the master branch only, at > least at the moment). > > The diffstat shows a net reduction of about 100 lines of code. > > group/gfs_controld/cpg-new.c | 161 ++++++++++++++-------------------------- > group/gfs_controld/gfs_daemon.h | 6 - > group/gfs_controld/main.c | 99 ++++++++++-------------- > group/gfs_controld/util.c | 43 ---------- > 4 files changed, 106 insertions(+), 203 deletions(-) Looks good, thanks. Dave