From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Wed, 14 Oct 2009 12:43:24 -0500 Subject: [Cluster-devel] Re: fence-agents: master - fencing: New option '--missing-as-off' to return OFF is machine is missing In-Reply-To: <20091014130639.2DE881201DA@lists.fedorahosted.org> References: <20091014130639.2DE881201DA@lists.fedorahosted.org> Message-ID: <20091014174324.GB28090@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > fencing: New option '--missing-as-off' to return OFF is machine is missing > > If a blade is not present (i.e. removed for maintenance), the fence_bladecenter > cannot check the state as it is reported empty. > > Resolves: bz#248006 > --- a/fence/agents/bladecenter/fence_bladecenter.py > +++ b/fence/agents/bladecenter/fence_bladecenter.py > @@ -30,7 +30,10 @@ def get_power_status(conn, options): > i = conn.log_expect(options, [ node_cmd, "system>" ] , int(options["-Y"])) > if i == 1: > ## Given blade number does not exist > - fail(EC_STATUS) > + if options.has_key("-M"): > + return "off" > + else: > + fail(EC_STATUS) I've never used bladecenter, so I don't know when a blade number doesn't exist. Does it reliably indicate that the blade is off? If so, then should we default to that without a new option? If not, then this option sounds bad, because it's effectively an automation of manual override, no? The typical issue with nodes removed for maintenance is that startup fencing tries to fence them and can't, for any agent. The solution to that has always been manual override or removing the node from cluster.conf. Dave