From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Mon, 21 Dec 2009 08:43:44 -0500 Subject: [Cluster-devel] [PATCH 2/2] gfs2: Use CALLER_ADDR0 macro. In-Reply-To: <1261387361.2200.6.camel@localhost> References: <1261332469-25298-1-git-send-email-tfransosi@gmail.com> <1261332469-25298-2-git-send-email-tfransosi@gmail.com> <1261387361.2200.6.camel@localhost> Message-ID: <20091221134344.GA17372@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Dec 21, 2009 at 09:22:41AM +0000, Steven Whitehouse wrote: > Hi, > > Looks fairly harmless, even though I don't entirely see the point. Do > you want me to add this to me tree? We also have a _RET_IP_ macro that does the same and has a much more useful name. And given that we need the address as void pointer to print it using our printk extension both seem a bit supoptimal. Given that a lot of tracing code needs this a bit of standardization would be useful - more important for the type to store the address than just the macro name.