From: Jan Kara <jack@suse.cz>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/6] fs: add hole punching to fallocate
Date: Tue, 16 Nov 2010 12:16:11 +0100 [thread overview]
Message-ID: <20101116111611.GA4757@quack.suse.cz> (raw)
In-Reply-To: <1289840723-3056-2-git-send-email-josef@redhat.com>
On Mon 15-11-10 12:05:18, Josef Bacik wrote:
> diff --git a/fs/open.c b/fs/open.c
> index 4197b9e..ab8dedf 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -223,7 +223,7 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
> return -EINVAL;
>
> /* Return error if mode is not supported */
> - if (mode && !(mode & FALLOC_FL_KEEP_SIZE))
> + if (mode && (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)))
Why not just:
if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)) ?
> diff --git a/include/linux/falloc.h b/include/linux/falloc.h
> index 3c15510..851cba2 100644
> --- a/include/linux/falloc.h
> +++ b/include/linux/falloc.h
> @@ -2,6 +2,7 @@
> #define _FALLOC_H_
>
> #define FALLOC_FL_KEEP_SIZE 0x01 /* default is extend size */
> +#define FALLOC_FL_PUNCH_HOLE 0X02 /* de-allocates range */
^ use lowercase 'x' please...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next parent reply other threads:[~2010-11-16 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1289840723-3056-1-git-send-email-josef@redhat.com>
[not found] ` <1289840723-3056-2-git-send-email-josef@redhat.com>
2010-11-16 11:16 ` Jan Kara [this message]
2010-11-16 11:43 ` [Cluster-devel] [PATCH 1/6] fs: add hole punching to fallocate Jan Kara
[not found] ` <20101116125249.GB31957@dhcp231-156.rdu.redhat.com>
2010-11-16 13:14 ` Jan Kara
[not found] ` <1289840723-3056-5-git-send-email-josef@redhat.com>
2010-11-16 11:52 ` [Cluster-devel] [PATCH 4/6] Ext4: fail if we try to use hole punch Jan Kara
[not found] ` <1289840723-3056-4-git-send-email-josef@redhat.com>
2010-11-16 11:50 ` [Cluster-devel] [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly Jan Kara
2010-11-17 23:27 ` Joel Becker
[not found] <1290044780-2902-1-git-send-email-josef@redhat.com>
[not found] ` <1290044780-2902-2-git-send-email-josef@redhat.com>
2010-11-18 23:43 ` [Cluster-devel] [PATCH 1/6] fs: add hole punching to fallocate Jan Kara
[not found] <1289248327-16308-1-git-send-email-josef@redhat.com>
[not found] ` <20101109011222.GD2715@dastard>
[not found] ` <20101109033038.GF3099@thunk.org>
[not found] ` <20101109044242.GH2715@dastard>
[not found] ` <20101109214147.GK3099@thunk.org>
2010-11-09 21:53 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116111611.GA4757@quack.suse.cz \
--to=jack@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).