From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ryan O'Hara <rohara@redhat.com>
Date: Wed, 2 Feb 2011 17:34:59 -0600
Subject: [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if
 disabled
In-Reply-To: <1296688290.26428.0.camel@localhost.localdomain>
References: <1296687674-23121-1-git-send-email-rohara@redhat.com>
	<1296688290.26428.0.camel@localhost.localdomain>
Message-ID: <20110202233459.GA21566@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Wed, Feb 02, 2011 at 06:11:30PM -0500, Lon Hohberger wrote:
> On Wed, 2011-02-02 at 17:01 -0600, Ryan O'Hara wrote:
> > This patch checks that dbus signals are not disabled before sending a
> > dbus signal.
> > 
> > Signed-off-by: Ryan O'Hara <rohara@redhat.com>
> > ---
> >  fence/fenced/recover.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/fence/fenced/recover.c b/fence/fenced/recover.c
> > index 5d7680d..6fdd116 100644
> > --- a/fence/fenced/recover.c
> > +++ b/fence/fenced/recover.c
> > @@ -384,7 +384,9 @@ void fence_victims(struct fd *fd)
> >  		log_error("fence %s %s", node->name,
> >  			  error ? "failed" : "success");
> >  
> > -		dbus_send(node->name, node->nodeid, error);
> > +		if (!optd_disable_dbus) {
> > +		    dbus_send(node->name, node->nodeid, error);
> > +		}
> 
> Indentation style doesn't match Dave's here or in dbus.c
> 
> I approve, but Dave really needs to sign off too.
> 
> -- Lon

Yeah. I fixed the indentation in my local repo. Not planning to post
another patch just for whitespace, unless someone insists.

Thanks for the review.

Ryan