* [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if disabled
@ 2011-02-02 23:01 Ryan O'Hara
2011-02-02 23:11 ` Lon Hohberger
0 siblings, 1 reply; 3+ messages in thread
From: Ryan O'Hara @ 2011-02-02 23:01 UTC (permalink / raw)
To: cluster-devel.redhat.com
This patch checks that dbus signals are not disabled before sending a
dbus signal.
Signed-off-by: Ryan O'Hara <rohara@redhat.com>
---
fence/fenced/recover.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fence/fenced/recover.c b/fence/fenced/recover.c
index 5d7680d..6fdd116 100644
--- a/fence/fenced/recover.c
+++ b/fence/fenced/recover.c
@@ -384,7 +384,9 @@ void fence_victims(struct fd *fd)
log_error("fence %s %s", node->name,
error ? "failed" : "success");
- dbus_send(node->name, node->nodeid, error);
+ if (!optd_disable_dbus) {
+ dbus_send(node->name, node->nodeid, error);
+ }
skip_log_message:
if (!error) {
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if disabled
2011-02-02 23:01 [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if disabled Ryan O'Hara
@ 2011-02-02 23:11 ` Lon Hohberger
2011-02-02 23:34 ` Ryan O'Hara
0 siblings, 1 reply; 3+ messages in thread
From: Lon Hohberger @ 2011-02-02 23:11 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Wed, 2011-02-02 at 17:01 -0600, Ryan O'Hara wrote:
> This patch checks that dbus signals are not disabled before sending a
> dbus signal.
>
> Signed-off-by: Ryan O'Hara <rohara@redhat.com>
> ---
> fence/fenced/recover.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fence/fenced/recover.c b/fence/fenced/recover.c
> index 5d7680d..6fdd116 100644
> --- a/fence/fenced/recover.c
> +++ b/fence/fenced/recover.c
> @@ -384,7 +384,9 @@ void fence_victims(struct fd *fd)
> log_error("fence %s %s", node->name,
> error ? "failed" : "success");
>
> - dbus_send(node->name, node->nodeid, error);
> + if (!optd_disable_dbus) {
> + dbus_send(node->name, node->nodeid, error);
> + }
Indentation style doesn't match Dave's here or in dbus.c
I approve, but Dave really needs to sign off too.
-- Lon
^ permalink raw reply [flat|nested] 3+ messages in thread* [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if disabled
2011-02-02 23:11 ` Lon Hohberger
@ 2011-02-02 23:34 ` Ryan O'Hara
0 siblings, 0 replies; 3+ messages in thread
From: Ryan O'Hara @ 2011-02-02 23:34 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Wed, Feb 02, 2011 at 06:11:30PM -0500, Lon Hohberger wrote:
> On Wed, 2011-02-02 at 17:01 -0600, Ryan O'Hara wrote:
> > This patch checks that dbus signals are not disabled before sending a
> > dbus signal.
> >
> > Signed-off-by: Ryan O'Hara <rohara@redhat.com>
> > ---
> > fence/fenced/recover.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/fence/fenced/recover.c b/fence/fenced/recover.c
> > index 5d7680d..6fdd116 100644
> > --- a/fence/fenced/recover.c
> > +++ b/fence/fenced/recover.c
> > @@ -384,7 +384,9 @@ void fence_victims(struct fd *fd)
> > log_error("fence %s %s", node->name,
> > error ? "failed" : "success");
> >
> > - dbus_send(node->name, node->nodeid, error);
> > + if (!optd_disable_dbus) {
> > + dbus_send(node->name, node->nodeid, error);
> > + }
>
> Indentation style doesn't match Dave's here or in dbus.c
>
> I approve, but Dave really needs to sign off too.
>
> -- Lon
Yeah. I fixed the indentation in my local repo. Not planning to post
another patch just for whitespace, unless someone insists.
Thanks for the review.
Ryan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-02 23:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-02 23:01 [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if disabled Ryan O'Hara
2011-02-02 23:11 ` Lon Hohberger
2011-02-02 23:34 ` Ryan O'Hara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).