From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lon Hohberger Date: Mon, 20 Jun 2011 09:28:19 -0400 Subject: [Cluster-devel] [PATCH] cman: fix ttl default if no value is specified In-Reply-To: <1308556853-3808-1-git-send-email-fdinitto@redhat.com> References: <1308556853-3808-1-git-send-email-fdinitto@redhat.com> Message-ID: <20110620132818.GQ10019@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jun 20, 2011 at 10:00:53AM +0200, Fabio M. Di Nitto wrote: > when specifing a multicast address, ttl was set to 0 unless > ttl was explicitly set in cluster.conf. I reviewed this; this patch looks correct, based on function and also this comment / code on lines 360-361: /* add the key to the objdb only if value is not default */ if (ttl != 1) { ... as well as understanding the objdb_get_int() function. ACK. Reviewed-by: Lon Hohberger -- Lon > > Resolves: rhbz#713977 > > Signed-off-by: Fabio M. Di Nitto > --- > cman/daemon/cman-preconfig.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c > index a890fb3..aeedf8b 100644 > --- a/cman/daemon/cman-preconfig.c > +++ b/cman/daemon/cman-preconfig.c > @@ -673,7 +673,7 @@ static int get_nodename(struct objdb_iface_ver0 *objdb) > if (objdb->object_find_next(find_handle2, &mcast_handle) == 0) { > > objdb_get_string(objdb, mcast_handle, "addr", &mcast_name); > - objdb_get_int(objdb, mcast_handle, "ttl", &ttl, 0); > + objdb_get_int(objdb, mcast_handle, "ttl", &ttl, ttl); > } > objdb->object_find_destroy(find_handle2); > } > -- > 1.7.4.4 > > -- Lon Hohberger - Red Hat, Inc.