* [Cluster-devel] [PATCH] cman: fix ttl default if no value is specified
@ 2011-06-20 8:00 Fabio M. Di Nitto
2011-06-20 13:28 ` Lon Hohberger
0 siblings, 1 reply; 2+ messages in thread
From: Fabio M. Di Nitto @ 2011-06-20 8:00 UTC (permalink / raw)
To: cluster-devel.redhat.com
when specifing a multicast address, ttl was set to 0 unless
ttl was explicitly set in cluster.conf.
Resolves: rhbz#713977
Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
cman/daemon/cman-preconfig.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
index a890fb3..aeedf8b 100644
--- a/cman/daemon/cman-preconfig.c
+++ b/cman/daemon/cman-preconfig.c
@@ -673,7 +673,7 @@ static int get_nodename(struct objdb_iface_ver0 *objdb)
if (objdb->object_find_next(find_handle2, &mcast_handle) == 0) {
objdb_get_string(objdb, mcast_handle, "addr", &mcast_name);
- objdb_get_int(objdb, mcast_handle, "ttl", &ttl, 0);
+ objdb_get_int(objdb, mcast_handle, "ttl", &ttl, ttl);
}
objdb->object_find_destroy(find_handle2);
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [PATCH] cman: fix ttl default if no value is specified
2011-06-20 8:00 [Cluster-devel] [PATCH] cman: fix ttl default if no value is specified Fabio M. Di Nitto
@ 2011-06-20 13:28 ` Lon Hohberger
0 siblings, 0 replies; 2+ messages in thread
From: Lon Hohberger @ 2011-06-20 13:28 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Mon, Jun 20, 2011 at 10:00:53AM +0200, Fabio M. Di Nitto wrote:
> when specifing a multicast address, ttl was set to 0 unless
> ttl was explicitly set in cluster.conf.
I reviewed this; this patch looks correct, based on function and also
this comment / code on lines 360-361:
/* add the key to the objdb only if value is not default */
if (ttl != 1) {
... as well as understanding the objdb_get_int() function.
ACK.
Reviewed-by: Lon Hohberger <lhh@redhat.com>
-- Lon
>
> Resolves: rhbz#713977
>
> Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
> ---
> cman/daemon/cman-preconfig.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
> index a890fb3..aeedf8b 100644
> --- a/cman/daemon/cman-preconfig.c
> +++ b/cman/daemon/cman-preconfig.c
> @@ -673,7 +673,7 @@ static int get_nodename(struct objdb_iface_ver0 *objdb)
> if (objdb->object_find_next(find_handle2, &mcast_handle) == 0) {
>
> objdb_get_string(objdb, mcast_handle, "addr", &mcast_name);
> - objdb_get_int(objdb, mcast_handle, "ttl", &ttl, 0);
> + objdb_get_int(objdb, mcast_handle, "ttl", &ttl, ttl);
> }
> objdb->object_find_destroy(find_handle2);
> }
> --
> 1.7.4.4
>
>
--
Lon Hohberger - Red Hat, Inc.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-20 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-20 8:00 [Cluster-devel] [PATCH] cman: fix ttl default if no value is specified Fabio M. Di Nitto
2011-06-20 13:28 ` Lon Hohberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).