From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Wed, 29 Jun 2011 18:17:31 -0400 Subject: [Cluster-devel] [PATCH] fs, dlm: Don't leak, don't do pointless NULL checks and use kzalloc In-Reply-To: References: <20110629214056.GA11350@redhat.com> Message-ID: <20110629221731.GB11350@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jun 29, 2011 at 11:51:00PM +0200, Jesper Juhl wrote: > > I don't think so; num_nodes won't be set to zero. > > Hmm. How so? Maybe I'm missing something obvious, but; > num_nodes is initialized to zero at the beginning of the function, which > means that we'll definately do the first allocation in the loop. Zero is meant to mean "first time through the loop". > We then set num_nodes equal to ls->ls_num_nodes - what guarantees that > this will not be zero so we won't do a second allocation (and leak) the > second time through the loop? That's just the nature of a lockspace, I guess -- it doesn't make sense or exist without nodes in it. I doubt any of the dlm code would work if that weren't true. Dave