From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v3] fs, dlm: don't do pointless NULL check, use kzalloc and fix order of arguments
Date: Mon, 11 Jul 2011 11:02:33 -0400 [thread overview]
Message-ID: <20110711150233.GC14426@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1107102252510.2818@swampdragon.chaosbits.net>
On Sun, Jul 10, 2011 at 10:54:31PM +0200, Jesper Juhl wrote:
> In fs/dlm/lock.c in the dlm_scan_waiters() function there are 3 small
> issues:
>
> 1) There's no need to test the return value of the allocation and do a
> memset if is succeedes. Just use kzalloc() to obtain zeroed memory.
>
> 2) Since kfree() handles NULL pointers gracefully, the test of
> 'warned' against NULL before the kfree() after the loop is completely
> pointless. Remove it.
>
> 3) The arguments to kmalloc() (now kzalloc()) were swapped. Thanks to
> Dr. David Alan Gilbert for pointing this out.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Thanks, I pushed this and a patch for the other swapped kmalloc to the
next branch.
Dave
parent reply other threads:[~2011-07-11 15:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.LNX.2.00.1107102252510.2818@swampdragon.chaosbits.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711150233.GC14426@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).