* [Cluster-devel] [PATCH v3] fs, dlm: don't do pointless NULL check, use kzalloc and fix order of arguments
[not found] ` <alpine.LNX.2.00.1107102252510.2818@swampdragon.chaosbits.net>
@ 2011-07-11 15:02 ` David Teigland
0 siblings, 0 replies; only message in thread
From: David Teigland @ 2011-07-11 15:02 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Sun, Jul 10, 2011 at 10:54:31PM +0200, Jesper Juhl wrote:
> In fs/dlm/lock.c in the dlm_scan_waiters() function there are 3 small
> issues:
>
> 1) There's no need to test the return value of the allocation and do a
> memset if is succeedes. Just use kzalloc() to obtain zeroed memory.
>
> 2) Since kfree() handles NULL pointers gracefully, the test of
> 'warned' against NULL before the kfree() after the loop is completely
> pointless. Remove it.
>
> 3) The arguments to kmalloc() (now kzalloc()) were swapped. Thanks to
> Dr. David Alan Gilbert for pointing this out.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Thanks, I pushed this and a patch for the other swapped kmalloc to the
next branch.
Dave
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-07-11 15:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <alpine.LNX.2.00.1107021957130.16316@swampdragon.chaosbits.net>
[not found] ` <alpine.LNX.2.00.1107102252510.2818@swampdragon.chaosbits.net>
2011-07-11 15:02 ` [Cluster-devel] [PATCH v3] fs, dlm: don't do pointless NULL check, use kzalloc and fix order of arguments David Teigland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).