From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Teigland <teigland@redhat.com>
Date: Mon, 11 Jul 2011 11:02:33 -0400
Subject: [Cluster-devel] [PATCH v3] fs,
 dlm: don't do pointless NULL check, use kzalloc and fix order of arguments
In-Reply-To: <alpine.LNX.2.00.1107102252510.2818@swampdragon.chaosbits.net>
References: <alpine.LNX.2.00.1107021957130.16316@swampdragon.chaosbits.net>
	<alpine.LNX.2.00.1107102252510.2818@swampdragon.chaosbits.net>
Message-ID: <20110711150233.GC14426@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Sun, Jul 10, 2011 at 10:54:31PM +0200, Jesper Juhl wrote:
> In fs/dlm/lock.c in the dlm_scan_waiters() function there are 3 small
> issues:
> 
> 1) There's no need to test the return value of the allocation and do a
> memset if is succeedes. Just use kzalloc() to obtain zeroed memory.
> 
> 2) Since kfree() handles NULL pointers gracefully, the test of
> 'warned' against NULL before the kfree() after the loop is completely
> pointless. Remove it.
> 
> 3) The arguments to kmalloc() (now kzalloc()) were swapped. Thanks to
> Dr. David Alan Gilbert for pointing this out.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Thanks, I pushed this and a patch for the other swapped kmalloc to the
next branch.
Dave