From: Ryan O'Hara <rohara@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fence_kdump: Fix metadata
Date: Tue, 2 Aug 2011 11:03:03 -0500 [thread overview]
Message-ID: <20110802160303.GA29790@redhat.com> (raw)
In-Reply-To: <1312227230-5663-1-git-send-email-lhh@redhat.com>
ACK.
On Mon, Aug 01, 2011 at 03:33:50PM -0400, Lon Hohberger wrote:
> Having duplicate "verbose" parameters is not valid.
>
> Signed-off-by: Lon Hohberger <lhh@redhat.com>
> ---
> fence/agents/kdump/fence_kdump.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fence/agents/kdump/fence_kdump.c b/fence/agents/kdump/fence_kdump.c
> index 8fdb681..2844a3e 100644
> --- a/fence/agents/kdump/fence_kdump.c
> +++ b/fence/agents/kdump/fence_kdump.c
> @@ -230,7 +230,7 @@ do_action_metadata (const char *self)
> "Print version");
> fprintf (stdout, "\t</parameter>\n");
>
> - fprintf (stdout, "\t<parameter name=\"verbose\" unique=\"1\" required=\"0\">\n");
> + fprintf (stdout, "\t<parameter name=\"usage\" unique=\"1\" required=\"0\">\n");
> fprintf (stdout, "\t\t<getopt mixed=\"-h, --help\" />\n");
> fprintf (stdout, "\t\t<content type=\"boolean\" />\n");
> fprintf (stdout, "\t\t<shortdesc lang=\"en\">%s</shortdesc>\n",
> --
> 1.7.3.4
prev parent reply other threads:[~2011-08-02 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 19:33 [Cluster-devel] [PATCH] fence_kdump: Fix metadata Lon Hohberger
2011-08-02 16:03 ` Ryan O'Hara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802160303.GA29790@redhat.com \
--to=rohara@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).