From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lon Hohberger <lhh@redhat.com>
Date: Wed, 10 Aug 2011 20:44:26 -0400
Subject: [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager
In-Reply-To: <4E42CA38.607@redhat.com>
References: <4E42CA38.607@redhat.com>
Message-ID: <20110811004425.GE32361@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Wed, Aug 10, 2011 at 01:13:12PM -0500, Chris Feist wrote:
> Patch to fix common rgmanager scripts for use with pacemaker.

Oops... NACK

>  12 files changed, 53 insertions(+), 11 deletions(-)
>  mode change 100644 => 100755 rgmanager/src/resources/apache.sh
>  mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
>  mode change 100644 => 100755 rgmanager/src/resources/ip.sh
>  mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
>  mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
>  mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
>  mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
>  mode change 100644 => 100755 rgmanager/src/resources/utils/httpd-parse-config.pl

Modes didn't need to be changed.

> +			clog_service_status $CLOG_FAILED "$APAHCE_pid_file"

Typo ... APACHE

>  	status_check_pid "$MYSQL_pid_file"
> +	case $? in
> +		$OCF_NOT_RUNNING)
> +		clog_service_status $CLOG_FAILED "$MYSL_pid_file"

Typo ... MYSQL (happens twice in your patch)


Otherwise, good by me.

-- 
Lon Hohberger - Red Hat, Inc.