cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Dejan Muhamedagic <dejan@suse.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Fix ocf-tester to use bash when	testing agents
Date: Tue, 16 Aug 2011 17:09:22 +0200	[thread overview]
Message-ID: <20110816150921.GB3705@squib> (raw)
In-Reply-To: <4E47B8A2.6040502@redhat.com>

Hi Fabio and Chris,

On Sun, Aug 14, 2011 at 01:59:30PM +0200, Fabio M. Di Nitto wrote:
> On 08/12/2011 10:54 PM, Chris Feist wrote:
> > Simple workaround to prevent errors when testing rgmanager resource
> > agents with ocf tester.
> > 
> > Thanks,
> > Chris
> 
> It's probably best to send patches that involves the whole tree to
> ha-wg-technical, so that also the linux-ha people can look at them.

Yes, I missed the patch.

> The change is OK with me, but they might have other opinions.

There are some platforms and linux distribution which use a
shell different from bash. At least linux-ha RAs often don't
require bash. For instance, Debian's default shell is dash,
which is POSIX compliant and lighter than bash.

Chris, which errors did you encounter? On most (or all) of my
computers there is:

$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Dec  3  2009 /bin/sh -> bash

Cheers,

Dejan

> Fabio
> 



      reply	other threads:[~2011-08-16 15:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 20:54 [Cluster-devel] [PATCH] Fix ocf-tester to use bash when testing agents Chris Feist
2011-08-14 11:59 ` Fabio M. Di Nitto
2011-08-16 15:09   ` Dejan Muhamedagic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110816150921.GB3705@squib \
    --to=dejan@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).