[Cluster-devel] [PATCH] Fix ocf-tester to use bash when testing agents

[Cluster-devel] [PATCH] Fix ocf-tester to use bash when testing agents

[Chris Feist]

Simple workaround to prevent errors when testing rgmanager resource agents with 
ocf tester.

Thanks,
Chris
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fix-ocf-tester-to-use-bash-when-testing-agents.patch
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20110812/b4af47a5/attachment.ksh>

[Cluster-devel] [PATCH] Fix ocf-tester to use bash when testing agents

[Fabio M. Di Nitto]

On 08/12/2011 10:54 PM, Chris Feist wrote:
> Simple workaround to prevent errors when testing rgmanager resource
> agents with ocf tester.
> 
> Thanks,
> Chris

It's probably best to send patches that involves the whole tree to
ha-wg-technical, so that also the linux-ha people can look at them.

The change is OK with me, but they might have other opinions.

Fabio

[Cluster-devel] [PATCH] Fix ocf-tester to use bash when testing agents

[Dejan Muhamedagic]

Hi Fabio and Chris,

On Sun, Aug 14, 2011 at 01:59:30PM +0200, Fabio M. Di Nitto wrote:
> On 08/12/2011 10:54 PM, Chris Feist wrote:
> > Simple workaround to prevent errors when testing rgmanager resource
> > agents with ocf tester.
> > 
> > Thanks,
> > Chris
> 
> It's probably best to send patches that involves the whole tree to
> ha-wg-technical, so that also the linux-ha people can look at them.

Yes, I missed the patch.

> The change is OK with me, but they might have other opinions.

There are some platforms and linux distribution which use a
shell different from bash. At least linux-ha RAs often don't
require bash. For instance, Debian's default shell is dash,
which is POSIX compliant and lighter than bash.

Chris, which errors did you encounter? On most (or all) of my
computers there is:

$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Dec  3  2009 /bin/sh -> bash

Cheers,

Dejan

> Fabio
>