From: Jan Kara <jack@suse.cz>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] fallocate vs O_(D)SYNC
Date: Wed, 16 Nov 2011 14:39:15 +0100 [thread overview]
Message-ID: <20111116133915.GD8195@quack.suse.cz> (raw)
In-Reply-To: <20111116124550.GA11650@infradead.org>
On Wed 16-11-11 07:45:50, Christoph Hellwig wrote:
> On Wed, Nov 16, 2011 at 11:54:13AM +0100, Jan Kara wrote:
> > Yeah, only that nobody calls that fsync() automatically if the fd is
> > O_SYNC if I'm right. But maybe calling fdatasync() on the range which was
> > fallocated from sys_fallocate() if the fd is O_SYNC would do the trick for
> > most filesystems? That would match how we treat O_SYNC for other operations
> > as well. I'm just not sure whether XFS wouldn't take unnecessarily big hit
> > with this.
>
> This would work fine with XFS and be equivalent to what it does for
> O_DSYNC now. But I'd rather see every filesystem do the right thing
> and make sure the update actually is on disk when doing O_(D)SYNC
> operations.
OK, I don't really have a strong opinion here. Are you afraid that just
calling fsync() need not be enough to push all updates fallocate did to
disk?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-11-16 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 8:42 [Cluster-devel] fallocate vs O_(D)SYNC Christoph Hellwig
2011-11-16 9:43 ` Steven Whitehouse
2011-11-16 10:54 ` Jan Kara
2011-11-16 11:20 ` Steven Whitehouse
2011-11-16 12:45 ` Christoph Hellwig
2011-11-16 13:39 ` Jan Kara [this message]
2011-11-16 13:42 ` Christoph Hellwig
2011-11-16 15:57 ` Jan Kara
2011-11-16 16:16 ` Christoph Hellwig
[not found] ` <20111116161806.GP29279@shiny>
[not found] ` <20111116193540.GL23779@wotan.suse.de>
[not found] ` <20111116200310.GN23779@wotan.suse.de>
2011-11-17 10:16 ` Joel Becker
2011-11-18 12:09 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116133915.GD8195@quack.suse.cz \
--to=jack@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).