cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Jan Pokorný <jpokorny@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1b/2] resrules: fix free while passing the pointer to caller
Date: Mon, 2 Apr 2012 17:46:23 +0200	[thread overview]
Message-ID: <20120402154623.GA27656@redhat.com> (raw)
In-Reply-To: <20120402112952.GA21558@redhat.com>

On 02/04/12 13:29 +0200, Jan Pokorn? wrote:
> What's worse, the caller could then access uninitialized memory
> through this pointer (e.g., print_resource_rule).

As Ryan noted, this is not true, as the pointer was always set to
NULL.  So the patch only eliminates hidden NOOP.

-- Jan



  reply	other threads:[~2012-04-02 15:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02  9:59 [Cluster-devel] [PATCH 0/2] rgmanager: spots in flattening-related parts Jan Pokorný
2012-04-02 10:06 ` [Cluster-devel] [PATCH 1/2] resrules: fix free while passing the pointer to caller Jan Pokorný
2012-04-02 11:29   ` [Cluster-devel] [PATCH 1b/2] " Jan Pokorný
2012-04-02 15:46     ` Jan Pokorný [this message]
2012-04-02 10:08 ` [Cluster-devel] [PATCH 2/2] resrules: print_resource_rule doc comment conformance Jan Pokorný
2012-04-02 10:24   ` [Cluster-devel] [PATCH 2b/2] " Jan Pokorný
2012-04-02 11:37   ` [Cluster-devel] [PATCH 2c/2] " Jan Pokorný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120402154623.GA27656@redhat.com \
    --to=jpokorny@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).