From: Jan Pokorný <jpokorny@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] rgmanager: reslist: nothing avoids using size_t
Date: Fri, 6 Apr 2012 19:44:20 +0200 [thread overview]
Message-ID: <20120406174420.GA660@redhat.com> (raw)
In-Reply-To: <20120406162809.GA31390@redhat.com>
+ fix comment typo
Signed-off-by: Jan Pokorn? <jpokorny@redhat.com>
---
reslist.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/reslist.c b/reslist.c
index e1695fb..f9924cd 100644
--- a/reslist.c
+++ b/reslist.c
@@ -70,7 +70,7 @@ _attr_value(resource_node_t *node, const char *attrname, const char *ptype)
resource_t *res;
resource_attr_t *ra;
char *c, p_type[32];
- ssize_t len;
+ size_t len;
int x;
if (!node)
@@ -99,11 +99,13 @@ _attr_value(resource_node_t *node, const char *attrname, const char *ptype)
c = strchr(ra->ra_value, '%');
if (!c) {
/* Someone doesn't care or uses older
- semantics on inheritance */
+ semantics of inheritance */
return _attr_value(node->rn_parent, ra->ra_value,
NULL);
}
+ /* Difference guaranteed to be non-negative
+ (for x >= 0: &ra->ra_value[x] >= &ra->ra_value[0]) */
len = (c - ra->ra_value);
memset(p_type, 0, sizeof(p_type));
memcpy(p_type, ra->ra_value, len);
--
1.7.3.4
next prev parent reply other threads:[~2012-04-06 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 16:28 [Cluster-devel] [PATCH] rgmanager: various cleanups regarding string functions jpokorny
2012-04-06 17:44 ` Jan Pokorný [this message]
2012-04-06 17:53 ` [Cluster-devel] [PATCH] rgmanager: reslist: sanitize act_dup Jan Pokorný
2012-04-06 19:38 ` [Cluster-devel] [PATCH] rgmanager: reslist: another string related cleanup Jan Pokorný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120406174420.GA660@redhat.com \
--to=jpokorny@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).