From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Pokorný Date: Fri, 6 Apr 2012 19:44:20 +0200 Subject: [Cluster-devel] [PATCH] rgmanager: reslist: nothing avoids using size_t In-Reply-To: <20120406162809.GA31390@redhat.com> Message-ID: <20120406174420.GA660@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit + fix comment typo Signed-off-by: Jan Pokorn? --- reslist.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/reslist.c b/reslist.c index e1695fb..f9924cd 100644 --- a/reslist.c +++ b/reslist.c @@ -70,7 +70,7 @@ _attr_value(resource_node_t *node, const char *attrname, const char *ptype) resource_t *res; resource_attr_t *ra; char *c, p_type[32]; - ssize_t len; + size_t len; int x; if (!node) @@ -99,11 +99,13 @@ _attr_value(resource_node_t *node, const char *attrname, const char *ptype) c = strchr(ra->ra_value, '%'); if (!c) { /* Someone doesn't care or uses older - semantics on inheritance */ + semantics of inheritance */ return _attr_value(node->rn_parent, ra->ra_value, NULL); } + /* Difference guaranteed to be non-negative + (for x >= 0: &ra->ra_value[x] >= &ra->ra_value[0]) */ len = (c - ra->ra_value); memset(p_type, 0, sizeof(p_type)); memcpy(p_type, ra->ra_value, len); -- 1.7.3.4