From: Ryan McCabe <rmccabe@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/5] rgmanager: Don't immediately stop services that have started sucessfully
Date: Thu, 28 Jun 2012 15:57:46 -0400 [thread overview]
Message-ID: <20120628195743.GA80007@redhat.com> (raw)
This patch fixes a bug that caused services to be started, then
immediately stopped during recovery. This occurred when a service
had its recovery policy set to relocate and was in a restricted
failover domain. If starting the service failed on other nodes in the
failover domain, the service would be restarted on the original node,
then immediately stopped, even if it had started successfully. This
patch causes rgmanager to leave the service running if it restarted
successfully.
Resolves: rhbz#789366
Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
---
rgmanager/src/daemons/rg_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rgmanager/src/daemons/rg_state.c b/rgmanager/src/daemons/rg_state.c
index a8b1e36..4357d21 100644
--- a/rgmanager/src/daemons/rg_state.c
+++ b/rgmanager/src/daemons/rg_state.c
@@ -2061,7 +2061,7 @@ exhausted:
svcName);
if (svc_start(svcName, RG_START_RECOVER) == 0) {
*new_owner = me;
- return RG_EFAIL;
+ return 0;
}
}
--
1.7.10.2
next reply other threads:[~2012-06-28 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 19:57 Ryan McCabe [this message]
2012-07-04 11:06 ` [Cluster-devel] [PATCH 3/5] rgmanager: Don't immediately stop services that have started sucessfully Fabio M. Di Nitto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628195743.GA80007@redhat.com \
--to=rmccabe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).