From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan McCabe Date: Wed, 25 Jul 2012 10:43:42 -0400 Subject: [Cluster-devel] [PATCH] fence_xvm: Fix incorrect success return codes Message-ID: <20120725144331.GA71022@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This patch fixes two places where fence_xvm will return success for fencing operations when fencing has failed due to the challenge/response failing. Signed-off-by: Ryan McCabe --- fence/agents/xvm/fence_xvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fence/agents/xvm/fence_xvm.c b/fence/agents/xvm/fence_xvm.c index d1ffb12..eb006fd 100644 --- a/fence/agents/xvm/fence_xvm.c +++ b/fence/agents/xvm/fence_xvm.c @@ -99,14 +99,14 @@ tcp_exchange(int fd, fence_auth_type_t auth, void *key, if (tcp_challenge(fd, auth, key, key_len, timeout) <= 0) { /* Challenge failed */ printf("Invalid response to challenge\n"); - return 0; + return 1; } /* Now they'll send us one, so we need to respond here */ dbg_printf(3, "Responding to TCP challenge\n"); if (tcp_response(fd, auth, key, key_len, timeout) <= 0) { printf("Invalid response to challenge\n"); - return 0; + return 1; } dbg_printf(2, "TCP Exchange + Authentication done... \n"); -- 1.7.10.4